From: "Tzvetomir Stoyanov (VMware)" <tz.stoyanov@gmail.com>
To: rostedt@goodmis.org
Cc: linux-trace-devel@vger.kernel.org
Subject: [PATCH v5 0/3] Add new trace-cmd record options: "--proc-map"
Date: Wed, 14 Aug 2019 11:47:09 +0300 [thread overview]
Message-ID: <20190814084712.28188-10-tz.stoyanov@gmail.com> (raw)
In-Reply-To: <20190814084712.28188-1-tz.stoyanov@gmail.com>
New options to trace-cmd record are added:
- "--proc-map" - Saves traced process(es) address map in trace.dat
file.
- "--user" - Executes the traced process as given user.
As "--proc-map" option uses trace-cmd ptrace logic, part of this code is
rewritten. There were some leftovers related to this logic, the code is
upadted.
[
v5 changes:
- Added new patch:
"Extend ptrace logic to work with multiple filtered pids"
It resolves "filter_pid" leftover in ptrace related logic.
- "--proc-map" does not depend on option -F, it works with any command,
specified as trace-cmd argument or option -P.
- Renamed "mmap" to "proc-map" - the option name and the names of
the functions, variables and defines related to this feature.
v4 changes:
- Added check for strdup() failure.
- Made input user string argument of change_user() and run_cmd()
constant.
- Added description of the new "--mmap" trace-cmd option in the
program's help and the man page. (Suggested by Slavomir Kaslev)
Problems, reported by Yordan Karadzhov:
- Improved the parsing of /proc/<pid>/maps. Made it not so strict, as it
failed on some machines due to different size of fields.
- Implemented trace_pid_mmap_free() cleanup function to free mmap
related resources at trace-cmd exit.
- Fixed potential problem with non-terminated string, returned by
readlink().
- Coding style fixes.
v3 changes:
- "--user" does not depend on option -F, it works with any command,
specified as trace-cmd argument.
- Changed tracecmd_search_task_mmap() API to return not only the library
name, but also the start and end memory addresses.
- Renamed *tracee* to *task*
- Improved resources cleanup, in case of an error.
- Removed (this) changelog from the commit message.
v2 changes:
- Check for errors in change_user(). If an error occurs while
changing the user, the message is printed and the traced
process is not executed.
- Replaced usage of tracecmd_add_option_v() with tracecmd_add_option() API.
- Added checks to prevent buffer overflow when sscanf (... "%s", buf) is used.
- Return error in case memory allocation fails.
- Return error if option string is not in the expected format.
- Sort memory maps and use binary search to find matching library in the map.
]
Tzvetomir Stoyanov (VMware) (3):
trace-cmd: Extend ptrace logic to work with multiple filtered pids
trace-cmd: Save the tracee address map into the trace.dat file.
trace-cmd: Add option to execute traced process as given user
Documentation/trace-cmd-record.1.txt | 6 +
include/trace-cmd/trace-cmd.h | 10 +
lib/trace-cmd/trace-input.c | 172 +++++++++++++++-
tracecmd/include/trace-local.h | 10 +
tracecmd/trace-record.c | 282 +++++++++++++++++++++++++--
tracecmd/trace-usage.c | 2 +
6 files changed, 464 insertions(+), 18 deletions(-)
--
2.21.0
next prev parent reply other threads:[~2019-08-14 8:47 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-14 8:47 [PATCH v2 0/8] Separate trace-cmd and libtracecmd code Tzvetomir Stoyanov (VMware)
2019-08-14 8:47 ` [PATCH v2 1/8] trace-cmd: Move trace-cmd-local.h from the application to the library Tzvetomir Stoyanov (VMware)
2019-08-14 8:47 ` [PATCH v2 2/8] trace-cmd: Move trace-output.c into the library code Tzvetomir Stoyanov (VMware)
2019-08-14 8:47 ` [PATCH v2 3/8] trace-cmd: Move trace-msg.c into the library Tzvetomir Stoyanov (VMware)
2019-08-14 8:47 ` [PATCH v2 4/8] trace-cmd: Move trace-cmd global variable "quiet" to libtracecmd Tzvetomir Stoyanov (VMware)
2019-08-28 19:59 ` Steven Rostedt
2019-08-29 11:39 ` Tzvetomir Stoyanov
2019-08-29 16:38 ` Steven Rostedt
2019-08-14 8:47 ` [PATCH v2 5/8] trace-cmd: Move trace-cmd global variable "debug" " Tzvetomir Stoyanov (VMware)
2019-08-28 20:01 ` Steven Rostedt
2019-08-14 8:47 ` [PATCH v2 6/8] trace-cmd: Move plog() function " Tzvetomir Stoyanov (VMware)
2019-08-28 20:15 ` Steven Rostedt
2019-08-14 8:47 ` [PATCH v2 7/8] trace-cmd: Move trace-cmd APIs from trace-cmd.h to trace-local.h Tzvetomir Stoyanov (VMware)
2019-08-28 20:17 ` Steven Rostedt
2019-08-14 8:47 ` [PATCH v2 8/8] trace-cmd: Move tracecmd_stack_tracer_status() function to libtracecmd Tzvetomir Stoyanov (VMware)
2019-08-28 20:21 ` Steven Rostedt
2019-09-03 12:24 ` Tzvetomir Stoyanov
2019-08-14 8:47 ` Tzvetomir Stoyanov (VMware) [this message]
2019-08-27 23:28 ` [PATCH v5 0/3] Add new trace-cmd record options: "--proc-map" Steven Rostedt
2019-08-14 8:47 ` [PATCH v5 1/3] trace-cmd: Extend ptrace logic to work with multiple filtered pids Tzvetomir Stoyanov (VMware)
2019-08-27 23:31 ` Steven Rostedt
2019-08-14 8:47 ` [PATCH v5 2/3] trace-cmd: Save the tracee address map into the trace.dat file Tzvetomir Stoyanov (VMware)
2019-08-14 8:47 ` [PATCH v5 3/3] trace-cmd: Add option to execute traced process as given user Tzvetomir Stoyanov (VMware)
2019-08-28 20:25 ` [PATCH v2 0/8] Separate trace-cmd and libtracecmd code Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190814084712.28188-10-tz.stoyanov@gmail.com \
--to=tz.stoyanov@gmail.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).