From: Steven Rostedt <rostedt@goodmis.org>
To: "Yordan Karadzhov (VMware)" <y.karadz@gmail.com>
Cc: linux-trace-devel@vger.kernel.org, mike.auty@gmail.com
Subject: Re: [PATCH v2 5/5] kernel-shark: Better formatting of the error messages from "Record"
Date: Tue, 27 Aug 2019 19:03:01 -0400 [thread overview]
Message-ID: <20190827190301.43fad2d3@gandalf.local.home> (raw)
In-Reply-To: <20190826155811.32021-6-y.karadz@gmail.com>
On Mon, 26 Aug 2019 18:58:11 +0300
"Yordan Karadzhov (VMware)" <y.karadz@gmail.com> wrote:
> Make the message easier to read and understand by separating the
> QProcess's error and the Standard error.
>
> Signed-off-by: Yordan Karadzhov (VMware) <y.karadz@gmail.com>
> ---
> kernel-shark/src/KsMainWindow.cpp | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/kernel-shark/src/KsMainWindow.cpp b/kernel-shark/src/KsMainWindow.cpp
> index 651cf59..a3b5ce7 100644
> --- a/kernel-shark/src/KsMainWindow.cpp
> +++ b/kernel-shark/src/KsMainWindow.cpp
> @@ -1211,9 +1211,10 @@ void KsMainWindow::_captureError(QProcess::ProcessError error)
>
> void KsMainWindow::_captureErrorMessage(QProcess *capture)
> {
> - QString message = "Capture process failed:<br>";
> + QString message = "Capture process failed: ";
>
> message += capture->errorString();
> + message += "<br>Standard Error :";
I changed the above to: "<br>Standard Error: ", as I added:
echo "this is an error" >&2
exit 1
to kshark-su-record and the current patch produces:
ERROR: Capture process failed: Unknown error
Standard Error :this is an error
Where I think the below looks better:
ERROR: Capture process failed: Unknown error
Standard Error: this is an error
-- Steve
> message += capture->readAllStandardError();
> _error(message, "captureFinishedErr", false, false);
> }
prev parent reply other threads:[~2019-08-27 23:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-26 15:58 [PATCH v2 0/5] Handle the case when KernelShark is started as Root Yordan Karadzhov (VMware)
2019-08-26 15:58 ` [PATCH v2 1/5] kernel-shark: Show warning message when running " Yordan Karadzhov (VMware)
2019-08-27 22:22 ` Steven Rostedt
2019-09-19 20:32 ` Steven Rostedt
2019-09-20 10:27 ` Yordan Karadzhov (VMware)
2019-08-26 15:58 ` [PATCH v2 2/5] kernel-shark: Don't use pkexec " Yordan Karadzhov (VMware)
2019-08-26 15:58 ` [PATCH v2 3/5] kernel-shark: Use standart error message in KsMainWindow::_record() Yordan Karadzhov (VMware)
2019-08-26 15:58 ` [PATCH v2 4/5] kernel-shark: Optimize the error messages when "Record" fails to start Yordan Karadzhov (VMware)
2019-08-26 15:58 ` [PATCH v2 5/5] kernel-shark: Better formatting of the error messages from "Record" Yordan Karadzhov (VMware)
2019-08-27 23:03 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190827190301.43fad2d3@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=mike.auty@gmail.com \
--cc=y.karadz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).