From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 013B4C3A5A1 for ; Wed, 28 Aug 2019 20:01:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CF0C322CED for ; Wed, 28 Aug 2019 20:01:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726697AbfH1UBH (ORCPT ); Wed, 28 Aug 2019 16:01:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:41076 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726315AbfH1UBH (ORCPT ); Wed, 28 Aug 2019 16:01:07 -0400 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7A81622CED; Wed, 28 Aug 2019 20:01:06 +0000 (UTC) Date: Wed, 28 Aug 2019 16:01:05 -0400 From: Steven Rostedt To: "Tzvetomir Stoyanov (VMware)" Cc: linux-trace-devel@vger.kernel.org Subject: Re: [PATCH v2 5/8] trace-cmd: Move trace-cmd global variable "debug" to libtracecmd Message-ID: <20190828160105.7f524fa0@gandalf.local.home> In-Reply-To: <20190814084712.28188-6-tz.stoyanov@gmail.com> References: <20190814084712.28188-1-tz.stoyanov@gmail.com> <20190814084712.28188-6-tz.stoyanov@gmail.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-trace-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org On Wed, 14 Aug 2019 11:47:05 +0300 "Tzvetomir Stoyanov (VMware)" wrote: > A trace-cmd global variable "debug" is used from libtracecmd and > should be defined there. A new library APIs are implemented to > access it: > void tracecmd_set_debug(bool debug); > bool tracecmd_get_debug(void); > I was thinking of doing a descriptor for this too, but screw it. Debug is debug ;-) -- Steve