From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 259F7C3A59F for ; Thu, 29 Aug 2019 18:00:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 044292339E for ; Thu, 29 Aug 2019 18:00:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727944AbfH2SAN (ORCPT ); Thu, 29 Aug 2019 14:00:13 -0400 Received: from mail.kernel.org ([198.145.29.99]:50416 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726810AbfH2SAN (ORCPT ); Thu, 29 Aug 2019 14:00:13 -0400 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 31A132070B; Thu, 29 Aug 2019 18:00:12 +0000 (UTC) Date: Thu, 29 Aug 2019 14:00:10 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org, linux-trace-devel@vger.kernel.org Cc: Arnaldo Carvalho de Melo , Ingo Molnar , Jiri Olsa , Namhyung Kim , Andrew Morton , Patrick McLean , Tzvetomir Stoyanov Subject: Re: [PATCH 0/3] tools lib traceevent: Fixing the API to be less policy driven Message-ID: <20190829140010.60d75297@gandalf.local.home> In-Reply-To: <20190805204312.169565525@goodmis.org> References: <20190805204312.169565525@goodmis.org> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-trace-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org On Mon, 05 Aug 2019 16:43:12 -0400 Steven Rostedt wrote: > Hi Arnaldo and Jiri, Hi Arnaldo, I think these fell through the cracks. -- Steve > > We are still working on getting libtraceevent ready to be a stand alone > library. Part of that is to audit all the interfaces. We noticed > that the most the tep_print_*() interfaces define policy and limit > the way an application can display data. Instead of fixing this later > and being stuck with a limiting API that we must maintain for backward > compatibility, we removed and replaced most of it. perf was only affected > by a single function that was removed. These functions are replaced > by a more flexible one that allows the user to place what they want > where they want it (timestamps, event info, latency format, COMM, PID, etc). > > The other noticeable perf change, is that we changed the location to > where the plugins are loaded from: > > ${HOME}/.traceevent/plugins > > to > > ${HOME}/.local/lib/traceevent/plugins > > As Patrick McLean (Gentoo package maintainer) informed us of the > XGD layout. > > Should we have something the warns people if they have plugins in > the old directory. Should we move them on install? Currently, we > just ignore them. > > Anyway, please add these patches to tip. > > Thanks! > > -- Steve > > > Tzvetomir Stoyanov (3): > tools/lib/traceevent, tools/perf: Changes in tep_print_event_* APIs > tools/lib/traceevent: Remove tep_register_trace_clock() > tools/lib/traceevent: Change user's plugin directory > > ---- > tools/lib/traceevent/Makefile | 6 +- > tools/lib/traceevent/event-parse-api.c | 40 ---- > tools/lib/traceevent/event-parse-local.h | 6 - > tools/lib/traceevent/event-parse.c | 333 +++++++++++++++++-------------- > tools/lib/traceevent/event-parse.h | 30 +-- > tools/lib/traceevent/event-plugin.c | 2 +- > tools/perf/builtin-kmem.c | 3 +- > tools/perf/util/sort.c | 3 +- > tools/perf/util/trace-event-parse.c | 2 +- > 9 files changed, 207 insertions(+), 218 deletions(-)