From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0512C3A5A5 for ; Mon, 2 Sep 2019 16:01:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9B0ED21881 for ; Mon, 2 Sep 2019 16:01:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726581AbfIBQBr (ORCPT ); Mon, 2 Sep 2019 12:01:47 -0400 Received: from mga12.intel.com ([192.55.52.136]:5541 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726571AbfIBQBr (ORCPT ); Mon, 2 Sep 2019 12:01:47 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Sep 2019 09:01:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,459,1559545200"; d="scan'208";a="357510056" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga005.jf.intel.com with ESMTP; 02 Sep 2019 09:01:42 -0700 Received: from andy by smile with local (Exim 4.92.1) (envelope-from ) id 1i4olv-0004WG-EM; Mon, 02 Sep 2019 19:01:39 +0300 Date: Mon, 2 Sep 2019 19:01:39 +0300 From: Andy Shevchenko To: Petr Mladek Cc: Sakari Ailus , rafael@kernel.org, linux-kernel@vger.kernel.org, Rob Herring , Heikki Krogerus , devicetree@vger.kernel.org, linux-acpi@vger.kernel.org, Steven Rostedt , Arnaldo Carvalho de Melo , Tzvetomir Stoyanov , linux-trace-devel@vger.kernel.org, Jiri Olsa , Namhyung Kim Subject: Re: [PATCH v4 07/11] lib/vsprintf: Remove support for %pF and %pf in favour of %pS and %ps Message-ID: <20190902160139.GQ2680@smile.fi.intel.com> References: <20190902083240.20367-1-sakari.ailus@linux.intel.com> <20190902083240.20367-8-sakari.ailus@linux.intel.com> <20190902143935.xtd44jdvhjuc2wxe@pathway.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190902143935.xtd44jdvhjuc2wxe@pathway.suse.cz> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-trace-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org On Mon, Sep 02, 2019 at 04:39:35PM +0200, Petr Mladek wrote: > On Mon 2019-09-02 11:32:36, Sakari Ailus wrote: > > %pS and %ps are now the preferred conversion specifiers to print function > > names. The functionality is equivalent; remove the old, deprecated %pF > > and %pf support. > > Hmm, I see the following in master: > > $> git grep %pF > tools/lib/traceevent/Documentation/libtraceevent-func_apis.txt:or events have "%pF" or "%pS" parameter in its format string. It is common to > > $> git grep %pf > tools/lib/traceevent/event-parse.c: if (asprintf(&format, "%%pf: (NO FORMAT FOUND at %llx)\n", addr) < 0) > tools/lib/traceevent/event-parse.c: if (asprintf(&format, "%s: %s", "%pf", printk->printk) < 0) > > I wonder how this is related to printk(). In each case, it seems It's going thru binary printf() I suppose. The fist stage just saves the format string and argument addresses or so and prints in later on when user is looking for human-readable output. > that libtraceevent somehow implements the non-standard kernel > %p mofifiers. It looks error-prone to keep another %pf user > with the old semantic around. > > I am adding some tracing people into CC. -- With Best Regards, Andy Shevchenko