linux-trace-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v3 0/4] Separate trace-cmd and libtracecmd code
@ 2019-09-03 13:34 Tzvetomir Stoyanov (VMware)
  2019-09-03 13:34 ` [PATCH v3 1/4] trace-cmd: Move trace-cmd global variable "quiet" to libtracecmd Tzvetomir Stoyanov (VMware)
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Tzvetomir Stoyanov (VMware) @ 2019-09-03 13:34 UTC (permalink / raw)
  To: rostedt; +Cc: linux-trace-devel

libtracecmd is a library, containing functions that can be
used without the trace-cmd application. However, some of the
functions declared as libtracecmd APIs in trace-cmd.h
depend on trace-cmd context. That causes a problem when
other application uses the library. The problem can be
observed when running kerneshark and there is a python
module, loaded by the python plugin - there is a bunch
of warnings.
To resolve the problem, implementations of all trace-cmd
independent functions are moved into libtracecmd. All
libtracecmd functions, that depend on trace-cmd context
are removed from the library and from trace-cmd.h file.

[
  v3 changes:
   - Removed accepted patches from the series.
   - Added new patch: "Update descriptions of "debug" libtracecmd APIs".
   - Renamed "plog*" library APIs to "tracecmd_plog*".
   - Rmoved "tracecmd" prefix from local variables.
   - Renamed trace_set_log_file to tracecmd_set_logfile.
   - Changed tracecmd_set_quiet() and tracecmd_get_quiet() APIs to work
     per tracecmd_output handler.
 
  v2 changes:
   - Added a new patch: 
        Move trace-cmd-local.h from the application to the library.
   - Remove trace-output.c dependency of version.h. Moved FILE_VERSION_STRING
     define from top Makefile to trace-cmd-local.h.
]

Tzvetomir Stoyanov (VMware) (4):
  trace-cmd: Move trace-cmd global variable "quiet" to libtracecmd
  trace-cmd: Move plog() function to libtracecmd.
  trace-cmd: Move tracecmd_stack_tracer_status() function to libtracecmd
  trace-cmd: Update descriptions of "debug" libtracecmd APIs

 include/trace-cmd/trace-cmd.h           |   9 +-
 include/trace-cmd/trace-msg.h           |   3 -
 lib/trace-cmd/include/trace-cmd-local.h |   2 -
 lib/trace-cmd/trace-msg.c               |   8 +-
 lib/trace-cmd/trace-output.c            |  28 ++++-
 lib/trace-cmd/trace-util.c              | 139 ++++++++++++++++++++++--
 tracecmd/include/trace-local.h          |   2 -
 tracecmd/trace-cmd.c                    |   2 -
 tracecmd/trace-listen.c                 |  89 +++------------
 tracecmd/trace-record.c                 |  17 ++-
 tracecmd/trace-stack.c                  |  56 +---------
 11 files changed, 199 insertions(+), 156 deletions(-)

-- 
2.21.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2019-09-03 13:34 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-03 13:34 [PATCH v3 0/4] Separate trace-cmd and libtracecmd code Tzvetomir Stoyanov (VMware)
2019-09-03 13:34 ` [PATCH v3 1/4] trace-cmd: Move trace-cmd global variable "quiet" to libtracecmd Tzvetomir Stoyanov (VMware)
2019-09-03 13:34 ` [PATCH v3 2/4] trace-cmd: Move plog() function " Tzvetomir Stoyanov (VMware)
2019-09-03 13:34 ` [PATCH v3 3/4] trace-cmd: Move tracecmd_stack_tracer_status() " Tzvetomir Stoyanov (VMware)
2019-09-03 13:34 ` [PATCH v3 4/4] trace-cmd: Update descriptions of "debug" libtracecmd APIs Tzvetomir Stoyanov (VMware)

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).