RE: [PATCH ]trace-recorder.c

RE: [PATCH ]trace-recorder.c

[Uhanov, Kirill]

[-- Attachment #1: Type: text/plain, Size: 2725 bytes --]

Hope is ok if I just add sign-off file.
Thanks, Kirill

-----Original Message-----
From: Steven Rostedt <rostedt@goodmis.org> 
Sent: Saturday, August 31, 2019 12:45 AM
To: Uhanov, Kirill <kirill.uhanov@intel.com>
Cc: linux-trace-devel@vger.kernel.org
Subject: Re: trace-recorder.c patch


Hi Kirill,

We try to follow the Linux kernel method of sending patches. You can read that here:

  https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html

If you only want to add this one fix and do not plan on sending other fixes (thus you may not care about the formal process), at a minimum we need you to add a:

 "Signed-off-by: Your Name <your-email>"

This is described in section 11 "Sign your work - the Developer’s Certificate of Origin" of the above link.

Thanks!

-- Steve


On Thu, 15 Aug 2019 15:13:28 +0000
"Uhanov, Kirill" <kirill.uhanov@intel.com> wrote:

> Hi All.
> 
> Looks like some typo in lib/trace-cmd/trace-recorder.c
> 
> Could you apply patch?
> 
> diff --git a/lib/trace-cmd/trace-recorder.c 
> b/lib/trace-cmd/trace-recorder.c
> 
> index 0bd0657..650b259 100644
> 
> --- a/lib/trace-cmd/trace-recorder.c
> 
> +++ b/lib/trace-cmd/trace-recorder.c
> 
> @@ -244,7 +244,7 @@ tracecmd_create_buffer_recorder_maxkb(const char 
> *file, int cpu, unsigned flags,
> 
>                              goto out;
> 
>                fd2 = open(file2, O_RDWR | O_CREAT | O_TRUNC | 
> O_LARGEFILE, 0644);
> 
> -             if (fd < 0)
> 
> +             if (fd2 < 0)
> 
>                              goto err;
> 
>                recorder = tracecmd_create_buffer_recorder_fd2(fd, fd2, 
> cpu, flags, buffer, maxkb);
> 
> Thanks, Kirill
> 
> --------------------------------------------------------------------
> Joint Stock Company Intel A/O
> Registered legal address: Krylatsky Hills Business Park,
> 17 Krylatskaya Str., Bldg 4, Moscow 121614, Russian Federation
> 
> This e-mail and any attachments may contain confidential material for 
> the sole use of the intended recipient(s). Any review or distribution 
> by others is strictly prohibited. If you are not the intended 
> recipient, please contact the sender and delete all copies.


--------------------------------------------------------------------
Joint Stock Company Intel A/O
Registered legal address: Krylatsky Hills Business Park,
17 Krylatskaya Str., Bldg 4, Moscow 121614,
Russian Federation

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.

[-- Attachment #2: sign-off.txt --]
[-- Type: text/plain, Size: 123 bytes --]

tools lib trace-cmd: Fix typo with file description condtitions

Signed-off-by: Kirill Uhanov <kirill.uhanov@intel.com>

[-- Attachment #3: kuhanov.patch --]
[-- Type: application/octet-stream, Size: 496 bytes --]

diff --git a/lib/trace-cmd/trace-recorder.c b/lib/trace-cmd/trace-recorder.c
index 0bd0657..650b259 100644
--- a/lib/trace-cmd/trace-recorder.c
+++ b/lib/trace-cmd/trace-recorder.c
@@ -244,7 +244,7 @@ tracecmd_create_buffer_recorder_maxkb(const char *file, int cpu, unsigned flags,
 		goto out;
 
 	fd2 = open(file2, O_RDWR | O_CREAT | O_TRUNC | O_LARGEFILE, 0644);
-	if (fd < 0)
+	if (fd2 < 0)
 		goto err;
 
 	recorder = tracecmd_create_buffer_recorder_fd2(fd, fd2, cpu, flags, buffer, maxkb);

Re: [PATCH ]trace-recorder.c

[Steven Rostedt]

On Mon, 2 Sep 2019 11:23:18 +0000
"Uhanov, Kirill" <kirill.uhanov@intel.com> wrote:

> Hope is ok if I just add sign-off file.

Hi Kirill,

Could you resend it again starting with "[PATCH]" in the subject, and
not as an attachment. Otherwise your patch doesn't get picked up by
Patchwork and it breaks the flow of adding patches into the git repo.

As I'm traveling, I can't enter your patch into the machine with the
git repo without it being in patchwork. If I was home, I would be able
to do it manually.

Thanks!

-- Steve