Linux-Trace-Devel Archive on lore.kernel.org
 help / color / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: "Uhanov, Kirill" <kirill.uhanov@intel.com>
Cc: "'linux-trace-devel@vger.kernel.org'" 
	<linux-trace-devel@vger.kernel.org>
Subject: Re: [PATCH] tools lib trace-cmd: Fix typo with file descriptors conditions.
Date: Wed, 4 Sep 2019 07:50:31 -0400
Message-ID: <20190904075031.447f0532@oasis.local.home> (raw)
In-Reply-To: <E9875C329132824C9E8D827BD6069E125C64F045@irsmsx110.ger.corp.intel.com>

On Wed, 4 Sep 2019 10:48:37 +0000
"Uhanov, Kirill" <kirill.uhanov@intel.com> wrote:

Hmm, Patchwork doesn't want to pick this up. Probably because of the
strange mime format that your mail client is using. I'll send this
patch for you (using a From line for you). But if you want to
contribute to Linux related projects, it may be a good idea to work
with other intel developers to fix your mail client such that patches
work as inlined.

Thanks!

-- Steve


> tools lib trace-cmd: Fix typo with file descriptor conditions
> 
> Signed-off-by: Kirill Uhanov <kirill.uhanov@intel.com>
> 
> 
> 
> diff --git a/lib/trace-cmd/trace-recorder.c b/lib/trace-cmd/trace-recorder.c
> 
> index 0bd0657..650b259 100644
> 
> --- a/lib/trace-cmd/trace-recorder.c
> 
> +++ b/lib/trace-cmd/trace-recorder.c
> 
> @@ -244,7 +244,7 @@ tracecmd_create_buffer_recorder_maxkb(const char *file, int cpu, unsigned flags,
> 
>                              goto out;
> 
>                fd2 = open(file2, O_RDWR | O_CREAT | O_TRUNC | O_LARGEFILE, 0644);
> 
> -              if (fd < 0)
> 
> +             if (fd2 < 0)
> 
>                              goto err;
> 
>                recorder = tracecmd_create_buffer_recorder_fd2(fd, fd2, cpu, flags, buffer, maxkb);
> 
> 
> 
> --------------------------------------------------------------------
> Joint Stock Company Intel A/O
> Registered legal address: Krylatsky Hills Business Park,
> 17 Krylatskaya Str., Bldg 4, Moscow 121614,
> Russian Federation
> 
> This e-mail and any attachments may contain confidential material for
> the sole use of the intended recipient(s). Any review or distribution
> by others is strictly prohibited. If you are not the intended
> recipient, please contact the sender and delete all copies.


           reply index

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <E9875C329132824C9E8D827BD6069E125C64F045@irsmsx110.ger.corp.intel.com>]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190904075031.447f0532@oasis.local.home \
    --to=rostedt@goodmis.org \
    --cc=kirill.uhanov@intel.com \
    --cc=linux-trace-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Trace-Devel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-trace-devel/0 linux-trace-devel/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-trace-devel linux-trace-devel/ https://lore.kernel.org/linux-trace-devel \
		linux-trace-devel@vger.kernel.org linux-trace-devel@archiver.kernel.org
	public-inbox-index linux-trace-devel


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-trace-devel


AGPL code for this site: git clone https://public-inbox.org/ public-inbox