From: Slavomir Kaslev <kaslevs@vmware.com>
To: rostedt@goodmis.org
Cc: linux-trace-devel@vger.kernel.org
Subject: [PATCH v14 13/13] trace-cmd: Add support for tracing VMware Workstation VMs by name
Date: Tue, 17 Sep 2019 16:15:38 +0300 [thread overview]
Message-ID: <20190917131538.31926-14-kaslevs@vmware.com> (raw)
In-Reply-To: <20190917131538.31926-1-kaslevs@vmware.com>
Read display name and CID of running VMware Workstation guests on startup so
that users can refer to them by name when recording.
Signed-off-by: Slavomir Kaslev <kaslevs@vmware.com>
---
tracecmd/trace-record.c | 72 +++++++++++++++++++++++++++++++++++++++++
1 file changed, 72 insertions(+)
diff --git a/tracecmd/trace-record.c b/tracecmd/trace-record.c
index 3aab6cb..41a95ea 100644
--- a/tracecmd/trace-record.c
+++ b/tracecmd/trace-record.c
@@ -2894,6 +2894,77 @@ next:
closedir(dir);
}
+static int load_vmw_guest(const char *vm, char **name, int *cid)
+{
+ size_t line_len = 0;
+ char *line = NULL;
+ char *p;
+ FILE *f;
+
+ f = fopen(vm, "r");
+ if (!f)
+ return -errno;
+
+ *cid = -1;
+ *name = NULL;
+ while (getline(&line, &line_len, f) != -1) {
+ if (strncmp(line, "displayName = ", 14) == 0) {
+ p = strrchr(line, '"');
+ if (p)
+ *p = '\0';
+ *name = strdup(line + 15);
+ if (!*name)
+ die("allocating guest name");
+ } else if (strncmp(line, "vmci0.id = ", 11) == 0) {
+ p = strrchr(line, '"');
+ if (p)
+ *p = '\0';
+ *cid = atoi(line + 12);
+ }
+ }
+
+ free(line);
+ fclose(f);
+ return 0;
+}
+
+static void read_vmw_guests(void)
+{
+ static bool initialized;
+ size_t line_len = 0;
+ char *line = NULL;
+ ssize_t ret;
+ FILE *f;
+
+ if (initialized)
+ return;
+
+ initialized = true;
+
+ f = popen("vmrun list", "r");
+ if (!f)
+ return;
+
+ /* Ignore the first line */
+ ret = getline(&line, &line_len, f);
+ while ((ret = getline(&line, &line_len, f)) != -1) {
+ struct guest guest = {};
+
+ if (ret > 0 && line[ret-1] == '\n')
+ line[ret-1] = '\0';
+ if (load_vmw_guest(line, &guest.name, &guest.cid))
+ continue;
+
+ guests = realloc(guests, (guests_len + 1) * sizeof(*guests));
+ if (!guests)
+ die("Can not allocate guest buffer");
+ guests[guests_len++] = guest;
+ }
+
+ free(line);
+ pclose(f);
+}
+
static char *parse_guest_name(char *guest, int *cid, int *port)
{
size_t i;
@@ -2915,6 +2986,7 @@ static char *parse_guest_name(char *guest, int *cid, int *port)
*cid = atoi(guest);
read_qemu_guests();
+ read_vmw_guests();
for (i = 0; i < guests_len; i++) {
if ((*cid > 0 && *cid == guests[i].cid) ||
strcmp(guest, guests[i].name) == 0) {
--
2.20.1
prev parent reply other threads:[~2019-09-17 13:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-17 13:15 [PATCH v14 00/13] Add VM kernel tracing over vsockets and FIFOs Slavomir Kaslev
2019-09-17 13:15 ` [PATCH v14 01/13] trace-cmd: Make ports unsigned int Slavomir Kaslev
2019-09-17 13:15 ` [PATCH v14 02/13] trace-cmd: Detect if vsockets are available Slavomir Kaslev
2019-09-17 13:15 ` [PATCH v14 03/13] trace-cmd: Add tracecmd_create_recorder_virt() function Slavomir Kaslev
2019-09-17 13:15 ` [PATCH v14 04/13] trace-cmd: Add VM tracing protocol messages Slavomir Kaslev
2019-09-17 13:15 ` [PATCH v14 05/13] trace-cmd: Add buffer instance flags for tracing in guest and agent context Slavomir Kaslev
2019-09-17 13:15 ` [PATCH v14 06/13] trace-cmd: Add VM kernel tracing over vsockets transport Slavomir Kaslev
2019-09-17 13:15 ` [PATCH v14 07/13] trace-cmd: Use splice(2) for vsockets if available Slavomir Kaslev
2019-09-17 13:15 ` [PATCH v14 08/13] trace-cmd: Switch stop recording signal to SIGUSR1 Slavomir Kaslev
2019-09-17 13:15 ` [PATCH v14 09/13] trace-cmd: Add `trace-cmd setup-guest` command Slavomir Kaslev
2019-09-17 13:15 ` [PATCH v14 10/13] trace-cmd: Try to autodetect number of guest CPUs in setup-guest if not specified Slavomir Kaslev
2019-09-17 13:15 ` [PATCH v14 11/13] trace-cmd: Add setup-guest flag for attaching FIFOs to the guest VM config Slavomir Kaslev
2019-09-17 13:15 ` [PATCH v14 12/13] trace-cmd: Add VM kernel tracing over FIFO transport Slavomir Kaslev
2019-09-17 13:15 ` Slavomir Kaslev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190917131538.31926-14-kaslevs@vmware.com \
--to=kaslevs@vmware.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).