From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Joe Perches <joe@perches.com>, Petr Mladek <pmladek@suse.com>,
linux-kernel@vger.kernel.org, rafael@kernel.org,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-acpi@vger.kernel.org, devicetree@vger.kernel.org,
Rob Herring <robh@kernel.org>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Tzvetomir Stoyanov <tstoyanov@vmware.com>,
linux-trace-devel@vger.kernel.org, Jiri Olsa <jolsa@redhat.com>,
Namhyung Kim <namhyung@kernel.org>
Subject: Re: [PATCH v6 01/12] tools lib traceevent: Convert remaining %p[fF] users to %p[sS]
Date: Wed, 18 Sep 2019 16:08:37 +0300 [thread overview]
Message-ID: <20190918130837.GQ5781@paasikivi.fi.intel.com> (raw)
In-Reply-To: <20190916103755.4c19eda9@gandalf.local.home>
Hi Steven,
On Mon, Sep 16, 2019 at 10:37:55AM -0400, Steven Rostedt wrote:
> > If you think that's an issue, I'll opt for another extension than %pfw,
> > which I chose originally since it's memorable --- fw for fwnode (names,
> > paths, and probably more in the future).
> >
>
> I'm fine with the switch, as long as newer tools know how to handle it.
>
> Make sure we also add a comment in the Linux kernel code that states
> that older kernels use to have 'f' and 'F' and that new tools look for
> 'fw' to denote that this isn't an older kernel. This way, people will
> hopefully not add another 'fX' pointer name.
Good point. I'll add a comment on this to make_bprint_args() in
tools/lib/traceevent/event-parse.c as well as in vsprintf.c.
--
Regards,
Sakari Ailus
sakari.ailus@linux.intel.com
prev parent reply other threads:[~2019-09-18 13:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190910084707.18380-1-sakari.ailus@linux.intel.com>
2019-09-10 8:46 ` [PATCH v6 01/12] tools lib traceevent: Convert remaining %p[fF] users to %p[sS] Sakari Ailus
2019-09-10 9:22 ` Andy Shevchenko
2019-09-10 11:18 ` Steven Rostedt
2019-09-10 17:18 ` Joe Perches
2019-09-10 18:26 ` Steven Rostedt
2019-09-10 18:42 ` Joe Perches
2019-09-10 19:03 ` Steven Rostedt
2019-09-10 19:44 ` Joe Perches
2019-09-16 11:41 ` Sakari Ailus
2019-09-16 14:37 ` Steven Rostedt
2019-09-18 13:08 ` Sakari Ailus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190918130837.GQ5781@paasikivi.fi.intel.com \
--to=sakari.ailus@linux.intel.com \
--cc=acme@redhat.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=joe@perches.com \
--cc=jolsa@redhat.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=namhyung@kernel.org \
--cc=pmladek@suse.com \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=rostedt@goodmis.org \
--cc=tstoyanov@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).