From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 963C1C4CEC9 for ; Wed, 18 Sep 2019 13:08:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7563C2067B for ; Wed, 18 Sep 2019 13:08:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729412AbfIRNIo (ORCPT ); Wed, 18 Sep 2019 09:08:44 -0400 Received: from mga02.intel.com ([134.134.136.20]:17819 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727001AbfIRNIn (ORCPT ); Wed, 18 Sep 2019 09:08:43 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Sep 2019 06:08:42 -0700 X-IronPort-AV: E=Sophos;i="5.64,520,1559545200"; d="scan'208";a="187761706" Received: from paasikivi.fi.intel.com ([10.237.72.42]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Sep 2019 06:08:39 -0700 Received: by paasikivi.fi.intel.com (Postfix, from userid 1000) id 38DF22075A; Wed, 18 Sep 2019 16:08:37 +0300 (EEST) Date: Wed, 18 Sep 2019 16:08:37 +0300 From: Sakari Ailus To: Steven Rostedt Cc: Joe Perches , Petr Mladek , linux-kernel@vger.kernel.org, rafael@kernel.org, Andy Shevchenko , linux-acpi@vger.kernel.org, devicetree@vger.kernel.org, Rob Herring , Heikki Krogerus , Arnaldo Carvalho de Melo , Tzvetomir Stoyanov , linux-trace-devel@vger.kernel.org, Jiri Olsa , Namhyung Kim Subject: Re: [PATCH v6 01/12] tools lib traceevent: Convert remaining %p[fF] users to %p[sS] Message-ID: <20190918130837.GQ5781@paasikivi.fi.intel.com> References: <20190910084707.18380-1-sakari.ailus@linux.intel.com> <20190910084707.18380-2-sakari.ailus@linux.intel.com> <20190910071837.2e9110f8@oasis.local.home> <61a2b2ab4693535850306f396aac2a328e1d5a21.camel@perches.com> <20190910142621.0bec208d@oasis.local.home> <20190910150303.5a0d3904@oasis.local.home> <20190916114158.GN5781@paasikivi.fi.intel.com> <20190916103755.4c19eda9@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190916103755.4c19eda9@gandalf.local.home> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-trace-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org Hi Steven, On Mon, Sep 16, 2019 at 10:37:55AM -0400, Steven Rostedt wrote: > > If you think that's an issue, I'll opt for another extension than %pfw, > > which I chose originally since it's memorable --- fw for fwnode (names, > > paths, and probably more in the future). > > > > I'm fine with the switch, as long as newer tools know how to handle it. > > Make sure we also add a comment in the Linux kernel code that states > that older kernels use to have 'f' and 'F' and that new tools look for > 'fw' to denote that this isn't an older kernel. This way, people will > hopefully not add another 'fX' pointer name. Good point. I'll add a comment on this to make_bprint_args() in tools/lib/traceevent/event-parse.c as well as in vsprintf.c. -- Regards, Sakari Ailus sakari.ailus@linux.intel.com