From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F402C3A5A6 for ; Thu, 19 Sep 2019 20:32:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 39F9721907 for ; Thu, 19 Sep 2019 20:32:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392371AbfISUcM (ORCPT ); Thu, 19 Sep 2019 16:32:12 -0400 Received: from mail.kernel.org ([198.145.29.99]:57926 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387854AbfISUcM (ORCPT ); Thu, 19 Sep 2019 16:32:12 -0400 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C7A70207FC; Thu, 19 Sep 2019 20:32:11 +0000 (UTC) Date: Thu, 19 Sep 2019 16:32:10 -0400 From: Steven Rostedt To: "Yordan Karadzhov (VMware)" Cc: linux-trace-devel@vger.kernel.org, mike.auty@gmail.com Subject: Re: [PATCH v2 1/5] kernel-shark: Show warning message when running as Root Message-ID: <20190919163210.7740f372@gandalf.local.home> In-Reply-To: <20190827182253.2d230e63@gandalf.local.home> References: <20190826155811.32021-1-y.karadz@gmail.com> <20190826155811.32021-2-y.karadz@gmail.com> <20190827182253.2d230e63@gandalf.local.home> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-trace-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org On Tue, 27 Aug 2019 18:22:53 -0400 Steven Rostedt wrote: > On Mon, 26 Aug 2019 18:58:07 +0300 > "Yordan Karadzhov (VMware)" wrote: > > > + warn.setText("KernelShark will have Root privileges."); > > + warn.setInformativeText("Continue on your own risk."); > > This wasn't updated. > > From: https://lore.kernel.org/linux-trace-devel/20190809091914.75f553b2@gandalf.local.home/ > > > > + QMessageBox warn; > > > + warn.setText("KernelShark will have Root privileges."); > > > + warn.setInformativeText("Continue on your one risk."); > > > > Probably better to say: > > > > "KernelShark is running with Root privileges." > > "Continue at your own risk." > > I could update the patch if you like, instead of sending out another > series. Let me finish the rest of the series. > We decided in our meeting that you were going to send a v3, right? Just want to make sure (too many things to keep track of ;-) Thanks! -- Steve