From: "Yordan Karadzhov (VMware)" <y.karadz@gmail.com>
To: rostedt@goodmis.org
Cc: linux-trace-devel@vger.kernel.org,
"Yordan Karadzhov (VMware)" <y.karadz@gmail.com>
Subject: [PATCH v3 0/5] Handle the case when KernelShark is started as Root
Date: Fri, 20 Sep 2019 13:28:47 +0300 [thread overview]
Message-ID: <20190920102852.22769-1-y.karadz@gmail.com> (raw)
A patch set implementing the improvements suggested here:
https://bugzilla.kernel.org/show_bug.cgi?id=204475
Plus a minor improvements of the error messages printed when something
goes wrong withe the "Record" dialog.
v2 changes:
- Correcting typos in patch 1/5
- Fixing a bug in patch 2/5. trace-cmd now gets correctly formatted list
of command line arguments.
- Patches 4/5 and 5/5 are new.
v3 changes:
- Polishing the text of the warning/error messages in patches 1/5 and
5/5. The modifications have been suggested by Steven.
Yordan Karadzhov (VMware) (5):
kernel-shark: Show warning message when running as Root
kernel-shark: Don't use pkexec when running as Root
kernel-shark: Use standart error message in KsMainWindow::_record()
kernel-shark: Optimize the error messages when "Record" fails to start
kernel-shark: Better formatting of the error messages from "Record"
kernel-shark/src/KsMainWindow.cpp | 90 +++++++++++++++++++++++--------
kernel-shark/src/KsMainWindow.hpp | 4 ++
2 files changed, 71 insertions(+), 23 deletions(-)
--
2.20.1
next reply other threads:[~2019-09-20 10:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-20 10:28 Yordan Karadzhov (VMware) [this message]
2019-09-20 10:28 ` [PATCH v3 1/5] kernel-shark: Show warning message when running as Root Yordan Karadzhov (VMware)
2019-09-20 10:28 ` [PATCH v3 2/5] kernel-shark: Don't use pkexec " Yordan Karadzhov (VMware)
2019-09-20 10:28 ` [PATCH v3 3/5] kernel-shark: Use standart error message in KsMainWindow::_record() Yordan Karadzhov (VMware)
2019-09-20 10:28 ` [PATCH v3 4/5] kernel-shark: Optimize the error messages when "Record" fails to start Yordan Karadzhov (VMware)
2019-09-20 10:28 ` [PATCH v3 5/5] kernel-shark: Better formatting of the error messages from "Record" Yordan Karadzhov (VMware)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190920102852.22769-1-y.karadz@gmail.com \
--to=y.karadz@gmail.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).