From: "Yordan Karadzhov (VMware)" <y.karadz@gmail.com>
To: rostedt@goodmis.org
Cc: linux-trace-devel@vger.kernel.org,
"Yordan Karadzhov (VMware)" <y.karadz@gmail.com>
Subject: [PATCH v3 3/5] kernel-shark: Use standart error message in KsMainWindow::_record()
Date: Fri, 20 Sep 2019 13:28:50 +0300 [thread overview]
Message-ID: <20190920102852.22769-4-y.karadz@gmail.com> (raw)
In-Reply-To: <20190920102852.22769-1-y.karadz@gmail.com>
The error message is printed using the method KsMainWindow::_error().
The message itself remains unchanged. If we want to change the message,
this can be done in another patch.
Signed-off-by: Yordan Karadzhov (VMware) <y.karadz@gmail.com>
---
kernel-shark/src/KsMainWindow.cpp | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/kernel-shark/src/KsMainWindow.cpp b/kernel-shark/src/KsMainWindow.cpp
index c220afb..e24b0f5 100644
--- a/kernel-shark/src/KsMainWindow.cpp
+++ b/kernel-shark/src/KsMainWindow.cpp
@@ -890,7 +890,6 @@ void KsMainWindow::_record()
#endif
if (geteuid() && !canDoAsRoot) {
- QErrorMessage *em = new QErrorMessage(this);
QString message;
message = "Record is currently not supported.";
@@ -899,8 +898,7 @@ void KsMainWindow::_record()
message += " ./cmake_clean.sh <br> cmake .. <br> make <br>";
message += " sudo make install";
- em->showMessage(message);
- qCritical() << "ERROR: " << message;
+ _error(message, "recordCantStart", false, false);
return;
}
--
2.20.1
next prev parent reply other threads:[~2019-09-20 10:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-20 10:28 [PATCH v3 0/5] Handle the case when KernelShark is started as Root Yordan Karadzhov (VMware)
2019-09-20 10:28 ` [PATCH v3 1/5] kernel-shark: Show warning message when running " Yordan Karadzhov (VMware)
2019-09-20 10:28 ` [PATCH v3 2/5] kernel-shark: Don't use pkexec " Yordan Karadzhov (VMware)
2019-09-20 10:28 ` Yordan Karadzhov (VMware) [this message]
2019-09-20 10:28 ` [PATCH v3 4/5] kernel-shark: Optimize the error messages when "Record" fails to start Yordan Karadzhov (VMware)
2019-09-20 10:28 ` [PATCH v3 5/5] kernel-shark: Better formatting of the error messages from "Record" Yordan Karadzhov (VMware)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190920102852.22769-4-y.karadz@gmail.com \
--to=y.karadz@gmail.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).