From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAC5EC4CEC9 for ; Fri, 20 Sep 2019 10:29:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BDE6B208C0 for ; Fri, 20 Sep 2019 10:29:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="L/S2ofa0" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2406004AbfITK3X (ORCPT ); Fri, 20 Sep 2019 06:29:23 -0400 Received: from mail-wr1-f49.google.com ([209.85.221.49]:43287 "EHLO mail-wr1-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404388AbfITK3X (ORCPT ); Fri, 20 Sep 2019 06:29:23 -0400 Received: by mail-wr1-f49.google.com with SMTP id q17so6184137wrx.10 for ; Fri, 20 Sep 2019 03:29:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=5VQRDEreEx1paZSQ75EmVrFR7kBb+Ofq2JA8YzXCGn8=; b=L/S2ofa0q7tQjItTQHn1pna99xi1KxFrTFhx3N5lq7vROE13mfilaWsoIdSNVf2t4O FW/jqi+5n7+a9cZgDfz8321GPtsb2Mnzgkj59B7vguu1p2IgsL+s8AberExDUyq9CDl3 JSTLALk0p1MVBO/PydKUY/4XRPPYSFRUFOeFRjt5YFpqU0ghhciNxDPVPiOYltmfR08g rSXZa6KgBcsppjq8Ty1xlT3bh0GPbyplAQa0mEQNrIMX1SghUiZXOM9mJSn16tj1ABrC HlJaVcN/aWdUa6C+bELccOuJHONw4RNT4KoSOtuAlo8o/ZdRdyuTYunRiEcwbB2hXZX5 GXdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=5VQRDEreEx1paZSQ75EmVrFR7kBb+Ofq2JA8YzXCGn8=; b=dqsYEA0rAf0l77ScQG+KcKgYcUB/J73RpC5RQux8k35qgnpr5vIHiHjxC7TQXa3nnK 2Zw21/TGjuwuds2AbaPet+AitWTUzYkgi7GfnWy3Q58P3K2pqaEB3eyaY6CNJ09y1GGu Ci797ApcfhOArla+BMymV5PcTvkfGSdYN8AOf7xPzPUrLmE/eO84FmzgUluvl2+FsKpy OUaE/1LAHGq6vqyK9xnSY3nuTOdcE0PaLn0ZcPycYIbk1tqnoz+QgXk35yZ588XSfl7b A5uTwJ7rHzSBz0TF+0aRv0cz6IijesDv7zYAfGCA61Oy8mjtfz3rvZwl8yLLref7YFUv mkHg== X-Gm-Message-State: APjAAAX3aKPLFxe8dlPluiM8UR4E/xEJIpkyqBtk3f9veibZmp/TH3XX ezjSnlxyTH+YlYZPv+mZRIU= X-Google-Smtp-Source: APXvYqwR4uwDXn62FgIwZQr2+zBb1BRyUy7uKvu+Rmik9fAErev6Dk76S0ZCuEVXKElMZioZP9Hbig== X-Received: by 2002:a05:6000:1632:: with SMTP id v18mr486218wrb.233.1568975360246; Fri, 20 Sep 2019 03:29:20 -0700 (PDT) Received: from mamba.eng.vmware.com ([146.247.46.5]) by smtp.gmail.com with ESMTPSA id k26sm1480136wmj.33.2019.09.20.03.29.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Sep 2019 03:29:19 -0700 (PDT) From: "Yordan Karadzhov (VMware)" To: rostedt@goodmis.org Cc: linux-trace-devel@vger.kernel.org, "Yordan Karadzhov (VMware)" Subject: [PATCH v3 5/5] kernel-shark: Better formatting of the error messages from "Record" Date: Fri, 20 Sep 2019 13:28:52 +0300 Message-Id: <20190920102852.22769-6-y.karadz@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190920102852.22769-1-y.karadz@gmail.com> References: <20190920102852.22769-1-y.karadz@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-trace-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org Make the message easier to read and understand by separating the QProcess's error and the Standard error. Signed-off-by: Yordan Karadzhov (VMware) --- kernel-shark/src/KsMainWindow.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/kernel-shark/src/KsMainWindow.cpp b/kernel-shark/src/KsMainWindow.cpp index 311aa87..a583f5f 100644 --- a/kernel-shark/src/KsMainWindow.cpp +++ b/kernel-shark/src/KsMainWindow.cpp @@ -1211,9 +1211,10 @@ void KsMainWindow::_captureError(QProcess::ProcessError error) void KsMainWindow::_captureErrorMessage(QProcess *capture) { - QString message = "Capture process failed:
"; + QString message = "Capture process failed: "; message += capture->errorString(); + message += "
Standard Error: "; message += capture->readAllStandardError(); _error(message, "captureFinishedErr", false, false); } -- 2.20.1