From: "Tzvetomir Stoyanov (VMware)" <tz.stoyanov@gmail.com>
To: rostedt@goodmis.org
Cc: linux-trace-devel@vger.kernel.org
Subject: [PATCH 1/2] trace-cmd: Reset CPU mask after setting it in trace-cmd record with option -M
Date: Wed, 25 Sep 2019 14:08:22 +0300 [thread overview]
Message-ID: <20190925110823.1242-2-tz.stoyanov@gmail.com> (raw)
In-Reply-To: <20190925110823.1242-1-tz.stoyanov@gmail.com>
When trace-cmd is run with option -M, to set the tracing cpumask, it was not reset
to its previous state. The trace-cmd record should put back the original value
after using -M for the tracing cpu masks.
Fixes https://bugzilla.kernel.org/show_bug.cgi?id=204941
Reported-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Signed-off-by: Tzvetomir Stoyanov (VMware) <tz.stoyanov@gmail.com>
---
tracecmd/trace-record.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tracecmd/trace-record.c b/tracecmd/trace-record.c
index 96d2c1a..69de82a 100644
--- a/tracecmd/trace-record.c
+++ b/tracecmd/trace-record.c
@@ -2403,6 +2403,7 @@ static void set_mask(struct buffer_instance *instance)
path = get_instance_file(instance, "tracing_cpumask");
if (!path)
die("could not allocate path");
+ reset_save_file(path, RESET_DEFAULT_PRIO);
ret = stat(path, &st);
if (ret < 0) {
--
2.21.0
next prev parent reply other threads:[~2019-09-25 11:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-25 11:08 [PATCH 0/2] Reset CPU mask Tzvetomir Stoyanov (VMware)
2019-09-25 11:08 ` Tzvetomir Stoyanov (VMware) [this message]
2019-09-25 11:08 ` [PATCH 2/2] trace-cmd: Reset CPU mask to its default value with "trace-cmd reset" Tzvetomir Stoyanov (VMware)
2019-09-30 18:44 ` Steven Rostedt
[not found] ` <CACGkJdseMqPBcM8YOUoZvssT68BFrsmriis4DaMK74cUZVpKvg@mail.gmail.com>
2019-10-01 13:52 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190925110823.1242-2-tz.stoyanov@gmail.com \
--to=tz.stoyanov@gmail.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).