From: Slavomir Kaslev <kaslevs@vmware.com>
To: rostedt@goodmis.org
Cc: linux-trace-devel@vger.kernel.org
Subject: [PATCH v15 01/13] trace-cmd: Make ports unsigned int
Date: Tue, 8 Oct 2019 11:15:25 +0300 [thread overview]
Message-ID: <20191008081537.11536-2-kaslevs@vmware.com> (raw)
In-Reply-To: <20191008081537.11536-1-kaslevs@vmware.com>
Switch ports data type to unsigned int since vsocket ports are 32 bit unsigned
integers and sometimes cause overflow when stored in int variables.
Signed-off-by: Slavomir Kaslev <kaslevs@vmware.com>
---
include/trace-cmd/trace-cmd.h | 2 +-
lib/trace-cmd/trace-msg.c | 32 ++++++++++++++++++++++----------
tracecmd/trace-listen.c | 10 +++++-----
3 files changed, 28 insertions(+), 16 deletions(-)
diff --git a/include/trace-cmd/trace-cmd.h b/include/trace-cmd/trace-cmd.h
index 4090eba..00889fb 100644
--- a/include/trace-cmd/trace-cmd.h
+++ b/include/trace-cmd/trace-cmd.h
@@ -333,7 +333,7 @@ int tracecmd_msg_wait_close(struct tracecmd_msg_handle *msg_handle);
/* for server */
int tracecmd_msg_initial_setting(struct tracecmd_msg_handle *msg_handle);
int tracecmd_msg_send_port_array(struct tracecmd_msg_handle *msg_handle,
- int *ports);
+ unsigned *ports);
int tracecmd_msg_read_data(struct tracecmd_msg_handle *msg_handle, int ofd);
int tracecmd_msg_collect_data(struct tracecmd_msg_handle *msg_handle, int ofd);
bool tracecmd_msg_done(struct tracecmd_msg_handle *msg_handle);
diff --git a/lib/trace-cmd/trace-msg.c b/lib/trace-cmd/trace-msg.c
index 74c5254..4def7e6 100644
--- a/lib/trace-cmd/trace-msg.c
+++ b/lib/trace-cmd/trace-msg.c
@@ -161,12 +161,26 @@ static int make_tinit(struct tracecmd_msg_handle *msg_handle,
return 0;
}
-static int write_ints(char *buf, size_t buf_len, int *arr, int arr_len)
+/* test a to u */
+static int tatou(const char *s, unsigned int *res)
+{
+ long r;
+
+ r = atol(s);
+ if (r >= 0 && r <= UINT_MAX) {
+ *res = (unsigned int)r;
+ return 0;
+ }
+ return -1;
+}
+
+static int write_uints(char *buf, size_t buf_len,
+ unsigned int *arr, int arr_len)
{
int i, ret, tot = 0;
for (i = 0; i < arr_len; i++) {
- ret = snprintf(buf, buf_len, "%d", arr[i]);
+ ret = snprintf(buf, buf_len, "%u", arr[i]);
if (ret < 0)
return ret;
@@ -184,15 +198,15 @@ static int write_ints(char *buf, size_t buf_len, int *arr, int arr_len)
return tot;
}
-static int make_rinit(struct tracecmd_msg *msg, int cpus, int *ports)
+static int make_rinit(struct tracecmd_msg *msg, int cpus, unsigned int *ports)
{
int data_size;
- data_size = write_ints(NULL, 0, ports, cpus);
+ data_size = write_uints(NULL, 0, ports, cpus);
msg->buf = malloc(data_size);
if (!msg->buf)
return -ENOMEM;
- write_ints(msg->buf, data_size, ports, cpus);
+ write_uints(msg->buf, data_size, ports, cpus);
msg->rinit.cpus = htonl(cpus);
msg->hdr.size = htonl(ntohl(msg->hdr.size) + data_size);
@@ -442,7 +456,7 @@ int tracecmd_msg_send_init_data(struct tracecmd_msg_handle *msg_handle,
}
cpus = ntohl(msg.rinit.cpus);
- ports = malloc_or_die(sizeof(*ports) * cpus);
+ ports = malloc(sizeof(*ports) * cpus);
if (!ports) {
ret = -ENOMEM;
goto out;
@@ -450,13 +464,11 @@ int tracecmd_msg_send_init_data(struct tracecmd_msg_handle *msg_handle,
buf_end = msg.buf + buf_len;
for (i = 0, p = msg.buf; i < cpus; i++, p++) {
- if (p >= buf_end) {
+ if (p >= buf_end || tatou(p, &ports[i])) {
free(ports);
ret = -EINVAL;
goto error;
}
-
- ports[i] = atoi(p);
p = strchr(p, '\0');
}
@@ -588,7 +600,7 @@ error:
}
int tracecmd_msg_send_port_array(struct tracecmd_msg_handle *msg_handle,
- int *ports)
+ unsigned int *ports)
{
struct tracecmd_msg msg;
int ret;
diff --git a/tracecmd/trace-listen.c b/tracecmd/trace-listen.c
index 233d661..7798fe4 100644
--- a/tracecmd/trace-listen.c
+++ b/tracecmd/trace-listen.c
@@ -465,10 +465,10 @@ static int *create_all_readers(const char *node, const char *port,
{
int use_tcp = msg_handle->flags & TRACECMD_MSG_FL_USE_TCP;
char buf[BUFSIZ];
- int *port_array;
+ unsigned int *port_array;
int *pid_array;
- int start_port;
- int udp_port;
+ unsigned int start_port;
+ unsigned int udp_port;
int cpus = msg_handle->cpu_count;
int cpu;
int pid;
@@ -476,11 +476,11 @@ static int *create_all_readers(const char *node, const char *port,
if (!pagesize)
return NULL;
- port_array = malloc(sizeof(int) * cpus);
+ port_array = malloc(sizeof(*port_array) * cpus);
if (!port_array)
return NULL;
- pid_array = malloc(sizeof(int) * cpus);
+ pid_array = malloc(sizeof(*pid_array) * cpus);
if (!pid_array) {
free(port_array);
return NULL;
--
2.20.1
next prev parent reply other threads:[~2019-10-08 8:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-08 8:15 [PATCH v15 00/13] Add VM kernel tracing over vsockets and FIFOs Slavomir Kaslev
2019-10-08 8:15 ` Slavomir Kaslev [this message]
2019-10-08 8:15 ` [PATCH v15 02/13] trace-cmd: Detect if vsockets are available Slavomir Kaslev
2019-10-08 8:15 ` [PATCH v15 03/13] trace-cmd: Add tracecmd_create_recorder_virt() function Slavomir Kaslev
2019-10-08 8:15 ` [PATCH v15 04/13] trace-cmd: Add VM tracing protocol messages Slavomir Kaslev
2019-10-08 8:15 ` [PATCH v15 05/13] trace-cmd: Add buffer instance flags for tracing in guest and agent context Slavomir Kaslev
2019-10-08 8:15 ` [PATCH v15 06/13] trace-cmd: Add VM kernel tracing over vsockets transport Slavomir Kaslev
2019-10-08 8:15 ` [PATCH v15 07/13] trace-cmd: Use splice(2) for vsockets if available Slavomir Kaslev
2019-10-08 8:15 ` [PATCH v15 08/13] trace-cmd: Switch stop recording signal to SIGUSR1 Slavomir Kaslev
2019-10-08 8:15 ` [PATCH v15 09/13] trace-cmd: Add `trace-cmd setup-guest` command Slavomir Kaslev
2019-10-08 8:15 ` [PATCH v15 10/13] trace-cmd: Try to autodetect number of guest CPUs in setup-guest if not specified Slavomir Kaslev
2019-10-08 8:15 ` [PATCH v15 11/13] trace-cmd: Add setup-guest flag for attaching FIFOs to the guest VM config Slavomir Kaslev
2019-10-08 8:15 ` [PATCH v15 12/13] trace-cmd: Add VM kernel tracing over FIFO transport Slavomir Kaslev
2019-10-08 8:15 ` [PATCH v15 13/13] trace-cmd: Add support for tracing VMware Workstation VMs by name Slavomir Kaslev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191008081537.11536-2-kaslevs@vmware.com \
--to=kaslevs@vmware.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).