Linux-Trace-Devel Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH 0/4] Fix KernelShark appearance on dark color schemes
@ 2019-10-10 21:24 Mikhail Rudenko
  2019-10-10 21:24 ` [PATCH 1/4] kernel-shark: Set text color to black in KsDualMarker's QLabels Mikhail Rudenko
                   ` (4 more replies)
  0 siblings, 5 replies; 8+ messages in thread
From: Mikhail Rudenko @ 2019-10-10 21:24 UTC (permalink / raw)
  To: linux-trace-devel
  Cc: Steven Rostedt, Yordan Karadzhov (VMware), Mikhail Rudenko

Currently a few widgets in Kernel Shark UI use custom stylesheets,
unconditionally setting their background or text color (but not both!)
to hard-coded values. This has a side effect of widget text being
poorly readable on some color schemes (e.g. Breeze Dark, and dark
schemes in general). This patch series tries to address this issue.

The first three patches are trivial: they ensure that whenever the
background color of a widget is set to white via stylesheet, its text
color is set to black.

The fourth one changes "inactive" marker selection button style to
system default, making it look clickable on all color schemes.

Mikhail Rudenko (4):
  kernel-shark: Set text color to black in KsDualMarker's QLabels
  kernel-shark: Set text color to black in pointer position QLabel
  kernel-shark: Set text color to black in KsTraceGraph's axes labels
  kernel-shark: Change KsDualMarker's inactive button style to default

 kernel-shark/src/KsDualMarker.cpp | 11 ++---------
 kernel-shark/src/KsTraceGraph.cpp |  6 ++++--
 2 files changed, 6 insertions(+), 11 deletions(-)

--
2.23.0

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, back to index

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-10 21:24 [PATCH 0/4] Fix KernelShark appearance on dark color schemes Mikhail Rudenko
2019-10-10 21:24 ` [PATCH 1/4] kernel-shark: Set text color to black in KsDualMarker's QLabels Mikhail Rudenko
2019-10-10 21:24 ` [PATCH 2/4] kernel-shark: Set text color to black in pointer position QLabel Mikhail Rudenko
2019-10-10 21:24 ` [PATCH 3/4] kernel-shark: Set text color to black in KsTraceGraph's axes labels Mikhail Rudenko
2019-10-10 21:24 ` [PATCH 4/4] kernel-shark: Change KsDualMarker's inactive button style to default Mikhail Rudenko
2019-10-10 22:02 ` [PATCH 0/4] Fix KernelShark appearance on dark color schemes Steven Rostedt
2019-10-11 14:11   ` Yordan Karadzhov (VMware)
2019-10-11 18:18     ` Mikhail Rudenko

Linux-Trace-Devel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-trace-devel/0 linux-trace-devel/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-trace-devel linux-trace-devel/ https://lore.kernel.org/linux-trace-devel \
		linux-trace-devel@vger.kernel.org
	public-inbox-index linux-trace-devel

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-trace-devel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git