From: Steven Rostedt <rostedt@goodmis.org>
To: David Sterba <dsterba@suse.cz>
Cc: Qu Wenruo <wqu@suse.com>,
linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH v2] tools/lib/traceevent, perf tools: Handle %pU format correctly
Date: Thu, 17 Oct 2019 08:31:37 -0400 [thread overview]
Message-ID: <20191017083137.1984af24@gandalf.local.home> (raw)
In-Reply-To: <20191017115423.GH2751@twin.jikos.cz>
On Thu, 17 Oct 2019 13:54:23 +0200
David Sterba <dsterba@suse.cz> wrote:
> > So if there's an interest for very compact printing loop, something like
> > this produces the same output:
> >
> > for (i = 0; i < 8; i++) {
> > printf("%02X", buf[i]);
> > printf("%02X", buf[i]);
>
> Ok, test-before-post failure, this should be
>
> printf("%02X", buf[2 * i]);
> printf("%02X", buf[2 * i + 1]);
>
> > if (1 <= i && i <= 4)
> > putchar('-');
> > }
I'm fine if you want to post a v3 with this update.
-- Steve
prev parent reply other threads:[~2019-10-17 12:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-17 2:28 [PATCH v2] tools/lib/traceevent, perf tools: Handle %pU format correctly Qu Wenruo
2019-10-17 11:52 ` David Sterba
2019-10-17 11:54 ` David Sterba
2019-10-17 12:31 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191017083137.1984af24@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).