From: Greg Thelen <gthelen@google.com>
To: Steven Rostedt <rostedt@goodmis.org>,
"Yordan Karadzhov (VMware)" <y.karadz@gmail.com>
Cc: linux-trace-devel@vger.kernel.org, Greg Thelen <gthelen@google.com>
Subject: [PATCH 1/2] trace-cmd: refactor print_update
Date: Thu, 24 Oct 2019 23:39:56 -0700 [thread overview]
Message-ID: <20191025063957.21558-1-gthelen@google.com> (raw)
Match utils.mk convention and use a conditional macro for printing
'UPDATE' messages.
Signed-off-by: Greg Thelen <gthelen@google.com>
---
scripts/utils.mk | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/scripts/utils.mk b/scripts/utils.mk
index 98d7b3c726d8..8e4e4b5f3a4a 100644
--- a/scripts/utils.mk
+++ b/scripts/utils.mk
@@ -22,6 +22,7 @@ ifeq ($(VERBOSE),1)
print_plugin_obj_compile =
print_plugin_build =
print_install =
+ print_update =
else
Q = @
S = -s
@@ -33,6 +34,7 @@ else
print_plugin_build = echo ' $(GUI)BUILD PLUGIN '$(GOBJ);
print_static_lib_build = echo ' $(GUI)BUILD STATIC LIB '$(GOBJ);
print_install = echo ' $(GUI)INSTALL '$(GSPACE)$1' to $(DESTDIR_SQ)$2';
+ print_update = echo ' $(GUI)UPDATE '$(GOBJ);
endif
do_fpic_compile = \
@@ -96,7 +98,7 @@ define update_version.h
if [ -r $@ ] && cmp -s $@ $@.tmp; then \
rm -f $@.tmp; \
else \
- echo ' UPDATE '$(notdir $(strip $@)); \
+ $(print_update) \
mv -f $@.tmp $@; \
fi);
endef
@@ -106,7 +108,7 @@ define update_dir
if [ -r $@ ] && cmp -s $@ $@.tmp; then \
rm -f $@.tmp; \
else \
- echo ' UPDATE '$(notdir $(strip $@)); \
+ $(print_update) \
mv -f $@.tmp $@; \
fi);
endef
--
2.24.0.rc0.303.g954a862665-goog
next reply other threads:[~2019-10-25 6:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-25 6:39 Greg Thelen [this message]
2019-10-25 6:39 ` [PATCH 2/2] trace-cmd: respect -s/--silent Greg Thelen
2019-10-26 15:46 ` [PATCH 1/2] trace-cmd: refactor print_update Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191025063957.21558-1-gthelen@google.com \
--to=gthelen@google.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=y.karadz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).