From: "Tzvetomir Stoyanov (VMware)" <tz.stoyanov@gmail.com>
To: rostedt@goodmis.org
Cc: linux-trace-devel@vger.kernel.org
Subject: [PATCH v14 02/19] trace-cmd: Add support for negative time offsets in trace.dat file
Date: Wed, 27 Nov 2019 16:02:30 +0200 [thread overview]
Message-ID: <20191127140247.258766-3-tz.stoyanov@gmail.com> (raw)
In-Reply-To: <20191127140247.258766-1-tz.stoyanov@gmail.com>
From: Tzvetomir Stoyanov <tstoyanov@vmware.com>
When synchronizing timestamps between different machines, there are cases
when the time offset is negative. This patch changes the way time offset is
written and read from trace.dat file - as signed decimal, instead of hex.
Signed-off-by: Tzvetomir Stoyanov <tstoyanov@vmware.com>
---
include/trace-cmd/trace-cmd.h | 2 +-
lib/trace-cmd/trace-input.c | 6 +++---
tracecmd/trace-read.c | 4 ++--
3 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/include/trace-cmd/trace-cmd.h b/include/trace-cmd/trace-cmd.h
index 9363a26..7f9cb73 100644
--- a/include/trace-cmd/trace-cmd.h
+++ b/include/trace-cmd/trace-cmd.h
@@ -138,7 +138,7 @@ const char *tracecmd_buffer_instance_name(struct tracecmd_input *handle, int ind
struct tracecmd_input *tracecmd_buffer_instance_handle(struct tracecmd_input *handle, int indx);
int tracecmd_is_buffer_instance(struct tracecmd_input *handle);
-void tracecmd_set_ts_offset(struct tracecmd_input *handle, unsigned long long offset);
+void tracecmd_set_ts_offset(struct tracecmd_input *handle, long long offset);
void tracecmd_set_ts2secs(struct tracecmd_input *handle, unsigned long long hz);
void tracecmd_print_events(struct tracecmd_input *handle, const char *regex);
diff --git a/lib/trace-cmd/trace-input.c b/lib/trace-cmd/trace-input.c
index 3b187e3..91362f3 100644
--- a/lib/trace-cmd/trace-input.c
+++ b/lib/trace-cmd/trace-input.c
@@ -90,7 +90,7 @@ struct tracecmd_input {
bool read_page;
bool use_pipe;
struct cpu_data *cpu_data;
- unsigned long long ts_offset;
+ long long ts_offset;
double ts2secs;
char * cpustats;
char * uname;
@@ -2127,7 +2127,7 @@ static int init_cpu(struct tracecmd_input *handle, int cpu)
}
void tracecmd_set_ts_offset(struct tracecmd_input *handle,
- unsigned long long offset)
+ long long offset)
{
handle->ts_offset = offset;
}
@@ -2305,7 +2305,7 @@ tracecmd_search_task_map(struct tracecmd_input *handle,
static int handle_options(struct tracecmd_input *handle)
{
- unsigned long long offset;
+ long long offset;
unsigned short option;
unsigned int size;
char *cpustats = NULL;
diff --git a/tracecmd/trace-read.c b/tracecmd/trace-read.c
index 4958fa8..1875b75 100644
--- a/tracecmd/trace-read.c
+++ b/tracecmd/trace-read.c
@@ -58,7 +58,7 @@ static struct list_head handle_list;
struct input_files {
struct list_head list;
const char *file;
- unsigned long long tsoffset;
+ long long tsoffset;
unsigned long long ts2secs;
};
static struct list_head input_files;
@@ -1453,7 +1453,7 @@ void trace_report (int argc, char **argv)
struct input_files *inputs;
struct handle_list *handles;
enum output_type otype;
- unsigned long long tsoffset = 0;
+ long long tsoffset = 0;
unsigned long long ts2secs = 0;
unsigned long long ts2sc;
int show_stat = 0;
--
2.23.0
next prev parent reply other threads:[~2019-11-27 14:02 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-27 14:02 [PATCH v14 00/19] Timestamp synchronization of host - guest Tzvetomir Stoyanov (VMware)
2019-11-27 14:02 ` [PATCH v14 01/19] trace-cmd: Implement new lib API: tracecmd_local_events_system() Tzvetomir Stoyanov (VMware)
2019-12-04 14:59 ` Steven Rostedt
2019-11-27 14:02 ` Tzvetomir Stoyanov (VMware) [this message]
2019-11-27 14:02 ` [PATCH v14 03/19] trace-cmd: Add implementations of htonll() and ntohll() Tzvetomir Stoyanov (VMware)
2019-11-27 14:02 ` [PATCH v14 04/19] trace-cmd: Add new library APIs for ftrace instances Tzvetomir Stoyanov (VMware)
2019-11-27 14:02 ` [PATCH v14 05/19] trace-cmd: Add new library API for local CPU count Tzvetomir Stoyanov (VMware)
2019-11-27 14:02 ` [PATCH v14 06/19] trace-cmd: Add new library API for reading ftrace buffers Tzvetomir Stoyanov (VMware)
2019-11-27 14:02 ` [PATCH v14 07/19] trace-cmd: Find and store pids of tasks, which run virtual CPUs of given VM Tzvetomir Stoyanov (VMware)
2019-11-27 14:02 ` [PATCH v14 08/19] trace-cmd: --del the tracee address map into the guest's trace.dat file Tzvetomir Stoyanov (VMware)
2019-11-27 14:02 ` [PATCH v14 09/19] trace-cmd: Implement new API tracecmd_add_option_v() Tzvetomir Stoyanov (VMware)
2019-11-27 14:02 ` [PATCH v14 10/19] trace-cmd: Add new API to generate a unique ID of the tracing session Tzvetomir Stoyanov (VMware)
2019-11-27 14:02 ` [PATCH v14 11/19] trace-cmd: Store the session tracing ID in the trace.dat file Tzvetomir Stoyanov (VMware)
2019-11-27 14:02 ` [PATCH v14 12/19] trace-cmd: Exchange tracing IDs between host and guest Tzvetomir Stoyanov (VMware)
2019-11-27 14:02 ` [PATCH v14 13/19] trace-cmd: Implement new option in trace.dat file: TRACECMD_OPTION_TIME_SHIFT Tzvetomir Stoyanov (VMware)
2019-11-27 14:02 ` [PATCH v14 14/19] trace-cmd: Add guest information in host's trace.dat file Tzvetomir Stoyanov (VMware)
2019-11-27 14:02 ` [PATCH v14 15/19] trace-cmd: Add host trace clock as guest trace argument Tzvetomir Stoyanov (VMware)
2019-11-27 14:02 ` [PATCH v14 16/19] trace-cmd: Refactor few trace-cmd internal functions Tzvetomir Stoyanov (VMware)
2019-11-27 14:02 ` [PATCH v14 17/19] trace-cmd: Basic infrastructure for host - guest timestamp synchronization Tzvetomir Stoyanov (VMware)
2019-11-27 14:02 ` [PATCH v14 18/19] trace-cmd: [POC] PTP-like algorithm " Tzvetomir Stoyanov (VMware)
2019-11-27 14:02 ` [PATCH v14 19/19] trace-cmd: Debug scripts for " Tzvetomir Stoyanov (VMware)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191127140247.258766-3-tz.stoyanov@gmail.com \
--to=tz.stoyanov@gmail.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).