From: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
Linux Trace Devel <linux-trace-devel@vger.kernel.org>,
arnaldo.melo@gmail.com,
Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: Re: [PATCH 1/2] libtraceevent: fix lib installation
Date: Mon, 2 Dec 2019 21:55:30 -0300 [thread overview]
Message-ID: <20191203005530.GB3247@kernel.org> (raw)
In-Reply-To: <20191202175307.40d5a3df@gandalf.local.home>
Em Mon, Dec 02, 2019 at 05:53:07PM -0500, Steven Rostedt escreveu:
> On Mon, 2 Dec 2019 12:40:49 +0000
> Sudip Mukherjee <sudipm.mukherjee@gmail.com> wrote:
>
> > Hi Steve,
> >
> > On Fri, Nov 15, 2019 at 11:36 AM Sudip Mukherjee
> > <sudipm.mukherjee@gmail.com> wrote:
> > >
> > > When we use 'O=' with make to build libtraceevent in a separate folder
> > > it fails to install libtraceevent.a and libtraceevent.so.1.1.0 with the
> > > error:
> > > INSTALL /home/sudip/linux/obj-trace/libtraceevent.a
> > > INSTALL /home/sudip/linux/obj-trace/libtraceevent.so.1.1.0
> > > cp: cannot stat 'libtraceevent.a': No such file or directory
> > > Makefile:225: recipe for target 'install_lib' failed
> > > make: *** [install_lib] Error 1
> > >
> > > I used the command:
> > > make O=../../../obj-trace DESTDIR=~/test prefix==/usr install
> > >
> > > It turns out libtraceevent Makefile, even though it builds in a separate
> > > folder, searches for libtraceevent.a and libtraceevent.so.1.1.0 in its
> > > source folder.
> > > So, add the 'OUTPUT' prefix to the source path so that 'make' looks for
> > > the files in the correct place.
> > >
> > > Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
> > > ---
> > > tools/lib/traceevent/Makefile | 1 +
> >
> > A gentle ping.
> > I know its the merge window now. But your ack for these two patches will allow
> > me to start with the debian workflow.
> >
>
> Thanks for the reminder. Yeah, these look fine, and I just tested them
> out.
>
> Arnaldo, can you take these in, and possibly get them into this merge
> window?
>
> Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Sure,
- Arnaldo
next prev parent reply other threads:[~2019-12-03 0:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-15 11:36 [PATCH 1/2] libtraceevent: fix lib installation Sudip Mukherjee
2019-11-15 11:36 ` [PATCH 2/2] libtraceevent: copy pkg-config file in output folder Sudip Mukherjee
2019-12-04 7:53 ` [tip: perf/urgent] libtraceevent: Copy pkg-config file to output folder when using O= tip-bot2 for Sudip Mukherjee
2019-12-02 12:40 ` [PATCH 1/2] libtraceevent: fix lib installation Sudip Mukherjee
2019-12-02 22:53 ` Steven Rostedt
2019-12-03 0:55 ` Arnaldo Carvalho de Melo [this message]
2019-12-04 7:53 ` [tip: perf/urgent] libtraceevent: Fix lib installation with O= tip-bot2 for Sudip Mukherjee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191203005530.GB3247@kernel.org \
--to=arnaldo.melo@gmail.com \
--cc=acme@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).