From: Sven Schnelle <svens@linux.ibm.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH 3/3] ftrace: fix endianness bug in histogram trigger
Date: Wed, 18 Dec 2019 16:26:39 +0100 [thread overview]
Message-ID: <20191218152639.GA8508@tuxmaker.boeblingen.de.ibm.com> (raw)
In-Reply-To: <20191218102423.755eefdc@gandalf.local.home>
Hi Steve,
On Wed, Dec 18, 2019 at 10:24:23AM -0500, Steven Rostedt wrote:
> On Wed, 18 Dec 2019 08:44:27 +0100
> Sven Schnelle <svens@linux.ibm.com> wrote:
>
> > At least on PA-RISC and s390 synthetic histogram triggers are failing
> > selftests because trace_event_raw_event_synth() always writes a 64 bit
> > values, but the reader expects a field->size sized value. On little endian
> > machines this doesn't hurt, but on big endian this makes the reader always
> > read zero values.
>
> Does this fix make the other one obsolete?
>
> https://lore.kernel.org/r/20191211110959.2baeb70f@gandalf.local.home
No, that's a completely different issue, so we need both.
Regards
Sven
next prev parent reply other threads:[~2019-12-18 15:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-18 7:44 ftrace fixes Sven Schnelle
2019-12-18 7:44 ` [PATCH 1/3] selftests/ftrace: fix glob selftest Sven Schnelle
2019-12-19 23:31 ` Steven Rostedt
2019-12-20 7:27 ` Masami Hiramatsu
2019-12-20 7:32 ` Sven Schnelle
2019-12-21 1:23 ` Steven Rostedt
2019-12-18 7:44 ` [PATCH 2/3] samples/trace_printk: wait for IRQ work to finish Sven Schnelle
2019-12-18 7:44 ` [PATCH 3/3] ftrace: fix endianness bug in histogram trigger Sven Schnelle
2019-12-18 15:24 ` Steven Rostedt
2019-12-18 15:26 ` Sven Schnelle [this message]
2019-12-19 23:33 ` Steven Rostedt
2019-12-20 15:25 ` Tom Zanussi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191218152639.GA8508@tuxmaker.boeblingen.de.ibm.com \
--to=svens@linux.ibm.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).