Re: [PATCH] trace-cmd: generate cscope.files when building cscope index

[Steven Rostedt <rostedt@goodmis.org>]

On Sun, 12 Jan 2020 14:05:37 -0500
Marcelo Diop-Gonzalez <marcgonzalez@google.com> wrote:

> Currently, running 'make cscope' gives this output:

Hi Marcelo!

> 
> rm -f cscope*
> find . -name '\.pc' -prune -o -name '*\.[ch]' -print -o -name '*\.[ch]pp' ! -name '\.#' -print | cscope -b -q
> cscope: no source files found
> make: *** [Makefile:351: cscope] Error 1
> 
> By default, cscope looks in cscope.files for the list of
> sources, so printing the source file list to this file
> fixes the above error.
> 
> Signed-off-by: Marcelo Diop-Gonzalez <marcgonzalez@google.com>
> ---
>  Makefile | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/Makefile b/Makefile
> index efd9ed4..0b15bf5 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -348,7 +348,8 @@ TAGS:	force
>  
>  cscope: force
>  	$(RM) cscope*
> -	$(call find_tag_files) | cscope -b -q
> +	$(call find_tag_files) > cscope.files
> +	cscope -b -q

I think the following should work too, without the need to create an
extra file:

diff --git a/Makefile b/Makefile
index efd9ed4b..782df41b 100644
--- a/Makefile
+++ b/Makefile
@@ -348,7 +348,7 @@ TAGS:	force
 
 cscope: force
 	$(RM) cscope*
-	$(call find_tag_files) | cscope -b -q
+	$(call find_tag_files) | cscope -b -q -i-
 
 install_plugins_traceevent: force
 	$(Q)$(MAKE) -C $(src)/lib/traceevent/plugins install_plugins


Care to test it out. And feel free to resend this version.

Thanks!

-- Steve