linux-trace-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH RFC] MAINTAINERS: add TRACE EVENT LIBRARY section
@ 2020-02-01 16:19 Lukas Bulwahn
  2020-02-01 18:14 ` Steven Rostedt
                   ` (2 more replies)
  0 siblings, 3 replies; 8+ messages in thread
From: Lukas Bulwahn @ 2020-02-01 16:19 UTC (permalink / raw)
  To: Tzvetomir Stoyanov, Steven Rostedt
  Cc: linux-trace-devel, linux-kernel, Lukas Bulwahn

The git history shows that the files under ./tools/lib/traceevent/ are
being developed and maintained by Tzetomir Stoyanov and Steven Rostedt
and are discussed on the linux-trace-devel list.

Add a suitable section in MAINTAINERS for patches to reach them.

This was identified with a small script that finds all files only
belonging to "THE REST" according to the current MAINTAINERS file, and I
acted upon its output.

Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
Ceco, Steven, I added the information based on what I could see from an
outsider view. Please change and more files to the entry if needed.

applies cleanly on current master and next-20200131

Ceco, congrats becoming a kernel maintainer :)

 MAINTAINERS | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 1f77fb8cdde3..17eb358c3fda 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -16903,6 +16903,13 @@ T:	git git://git.infradead.org/users/jjs/linux-tpmdd.git
 S:	Maintained
 F:	drivers/char/tpm/
 
+TRACE EVENT LIBRARY
+M:	Tzvetomir Stoyanov <tz.stoyanov@gmail.com>
+M:	Steven Rostedt <rostedt@goodmis.org>
+L:	linux-trace-devel@vger.kernel.org
+S:	Maintained
+F:	tools/lib/traceevent/
+
 TRACING
 M:	Steven Rostedt <rostedt@goodmis.org>
 M:	Ingo Molnar <mingo@redhat.com>
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [PATCH RFC] MAINTAINERS: add TRACE EVENT LIBRARY section
  2020-02-01 16:19 [PATCH RFC] MAINTAINERS: add TRACE EVENT LIBRARY section Lukas Bulwahn
@ 2020-02-01 18:14 ` Steven Rostedt
  2020-02-01 19:02   ` Arnaldo Carvalho de Melo
  2020-02-02  6:42 ` Tzvetomir Stoyanov
  2020-02-03 10:23 ` Andy Shevchenko
  2 siblings, 1 reply; 8+ messages in thread
From: Steven Rostedt @ 2020-02-01 18:14 UTC (permalink / raw)
  To: Lukas Bulwahn, Arnaldo Carvalho de Melo
  Cc: Tzvetomir Stoyanov, linux-trace-devel, linux-kernel

On Sat,  1 Feb 2020 17:19:31 +0100
Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote:

> The git history shows that the files under ./tools/lib/traceevent/ are
> being developed and maintained by Tzetomir Stoyanov and Steven Rostedt
> and are discussed on the linux-trace-devel list.
> 
> Add a suitable section in MAINTAINERS for patches to reach them.
> 
> This was identified with a small script that finds all files only
> belonging to "THE REST" according to the current MAINTAINERS file, and I
> acted upon its output.

Thanks Lukas!

Arnaldo, would you like to take this?

Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>

-- Steve

> 
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> ---
> Ceco, Steven, I added the information based on what I could see from an
> outsider view. Please change and more files to the entry if needed.
> 
> applies cleanly on current master and next-20200131
> 
> Ceco, congrats becoming a kernel maintainer :)
> 
>  MAINTAINERS | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 1f77fb8cdde3..17eb358c3fda 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -16903,6 +16903,13 @@ T:	git git://git.infradead.org/users/jjs/linux-tpmdd.git
>  S:	Maintained
>  F:	drivers/char/tpm/
>  
> +TRACE EVENT LIBRARY
> +M:	Tzvetomir Stoyanov <tz.stoyanov@gmail.com>
> +M:	Steven Rostedt <rostedt@goodmis.org>
> +L:	linux-trace-devel@vger.kernel.org
> +S:	Maintained
> +F:	tools/lib/traceevent/
> +
>  TRACING
>  M:	Steven Rostedt <rostedt@goodmis.org>
>  M:	Ingo Molnar <mingo@redhat.com>


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH RFC] MAINTAINERS: add TRACE EVENT LIBRARY section
  2020-02-01 18:14 ` Steven Rostedt
@ 2020-02-01 19:02   ` Arnaldo Carvalho de Melo
  2020-07-01 11:50     ` Lukas Bulwahn
  0 siblings, 1 reply; 8+ messages in thread
From: Arnaldo Carvalho de Melo @ 2020-02-01 19:02 UTC (permalink / raw)
  To: Steven Rostedt
  Cc: Lukas Bulwahn, Tzvetomir Stoyanov, linux-trace-devel, linux-kernel

Em Sat, Feb 01, 2020 at 01:14:53PM -0500, Steven Rostedt escreveu:
> On Sat,  1 Feb 2020 17:19:31 +0100
> Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote:
> 
> > The git history shows that the files under ./tools/lib/traceevent/ are
> > being developed and maintained by Tzetomir Stoyanov and Steven Rostedt
> > and are discussed on the linux-trace-devel list.
> > 
> > Add a suitable section in MAINTAINERS for patches to reach them.
> > 
> > This was identified with a small script that finds all files only
> > belonging to "THE REST" according to the current MAINTAINERS file, and I
> > acted upon its output.
> 
> Thanks Lukas!
> 
> Arnaldo, would you like to take this?
> 
> Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>

Sure
 
> -- Steve
> 
> > 
> > Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> > ---
> > Ceco, Steven, I added the information based on what I could see from an
> > outsider view. Please change and more files to the entry if needed.
> > 
> > applies cleanly on current master and next-20200131
> > 
> > Ceco, congrats becoming a kernel maintainer :)
> > 
> >  MAINTAINERS | 7 +++++++
> >  1 file changed, 7 insertions(+)
> > 
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 1f77fb8cdde3..17eb358c3fda 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -16903,6 +16903,13 @@ T:	git git://git.infradead.org/users/jjs/linux-tpmdd.git
> >  S:	Maintained
> >  F:	drivers/char/tpm/
> >  
> > +TRACE EVENT LIBRARY
> > +M:	Tzvetomir Stoyanov <tz.stoyanov@gmail.com>
> > +M:	Steven Rostedt <rostedt@goodmis.org>
> > +L:	linux-trace-devel@vger.kernel.org
> > +S:	Maintained
> > +F:	tools/lib/traceevent/
> > +
> >  TRACING
> >  M:	Steven Rostedt <rostedt@goodmis.org>
> >  M:	Ingo Molnar <mingo@redhat.com>
> 

-- 

- Arnaldo

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH RFC] MAINTAINERS: add TRACE EVENT LIBRARY section
  2020-02-01 16:19 [PATCH RFC] MAINTAINERS: add TRACE EVENT LIBRARY section Lukas Bulwahn
  2020-02-01 18:14 ` Steven Rostedt
@ 2020-02-02  6:42 ` Tzvetomir Stoyanov
  2020-02-03 10:23 ` Andy Shevchenko
  2 siblings, 0 replies; 8+ messages in thread
From: Tzvetomir Stoyanov @ 2020-02-02  6:42 UTC (permalink / raw)
  To: Lukas Bulwahn; +Cc: Steven Rostedt, linux-trace-devel, linux-kernel

On Sat, Feb 1, 2020 at 6:19 PM Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote:
>
> The git history shows that the files under ./tools/lib/traceevent/ are
> being developed and maintained by Tzetomir Stoyanov and Steven Rostedt
> and are discussed on the linux-trace-devel list.
>
> Add a suitable section in MAINTAINERS for patches to reach them.
>
> This was identified with a small script that finds all files only
> belonging to "THE REST" according to the current MAINTAINERS file, and I
> acted upon its output.
>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> ---
> Ceco, Steven, I added the information based on what I could see from an
> outsider view. Please change and more files to the entry if needed.
>
> applies cleanly on current master and next-20200131
>
> Ceco, congrats becoming a kernel maintainer :)
>
Thanks, Lukas!

>  MAINTAINERS | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 1f77fb8cdde3..17eb358c3fda 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -16903,6 +16903,13 @@ T:     git git://git.infradead.org/users/jjs/linux-tpmdd.git
>  S:     Maintained
>  F:     drivers/char/tpm/
>
> +TRACE EVENT LIBRARY
> +M:     Tzvetomir Stoyanov <tz.stoyanov@gmail.com>
> +M:     Steven Rostedt <rostedt@goodmis.org>
> +L:     linux-trace-devel@vger.kernel.org
> +S:     Maintained
> +F:     tools/lib/traceevent/
> +
>  TRACING
>  M:     Steven Rostedt <rostedt@goodmis.org>
>  M:     Ingo Molnar <mingo@redhat.com>
> --
> 2.17.1
>


-- 
Tzvetomir (Ceco) Stoyanov
VMware Open Source Technology Center

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH RFC] MAINTAINERS: add TRACE EVENT LIBRARY section
  2020-02-01 16:19 [PATCH RFC] MAINTAINERS: add TRACE EVENT LIBRARY section Lukas Bulwahn
  2020-02-01 18:14 ` Steven Rostedt
  2020-02-02  6:42 ` Tzvetomir Stoyanov
@ 2020-02-03 10:23 ` Andy Shevchenko
  2020-02-04  4:41   ` Lukas Bulwahn
  2 siblings, 1 reply; 8+ messages in thread
From: Andy Shevchenko @ 2020-02-03 10:23 UTC (permalink / raw)
  To: Lukas Bulwahn
  Cc: Tzvetomir Stoyanov, Steven Rostedt, linux-trace-devel,
	Linux Kernel Mailing List

On Sat, Feb 1, 2020 at 6:21 PM Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote:
>
> The git history shows that the files under ./tools/lib/traceevent/ are
> being developed and maintained by Tzetomir Stoyanov and Steven Rostedt
> and are discussed on the linux-trace-devel list.
>
> Add a suitable section in MAINTAINERS for patches to reach them.
>
> This was identified with a small script that finds all files only
> belonging to "THE REST" according to the current MAINTAINERS file, and I
> acted upon its output.

> +TRACE EVENT LIBRARY
> +M:     Tzvetomir Stoyanov <tz.stoyanov@gmail.com>
> +M:     Steven Rostedt <rostedt@goodmis.org>
> +L:     linux-trace-devel@vger.kernel.org
> +S:     Maintained
> +F:     tools/lib/traceevent/

Don't forget to run early mentioned scripts (in some other threads).

-- 
With Best Regards,
Andy Shevchenko

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH RFC] MAINTAINERS: add TRACE EVENT LIBRARY section
  2020-02-03 10:23 ` Andy Shevchenko
@ 2020-02-04  4:41   ` Lukas Bulwahn
  2020-02-04 11:12     ` Andy Shevchenko
  0 siblings, 1 reply; 8+ messages in thread
From: Lukas Bulwahn @ 2020-02-04  4:41 UTC (permalink / raw)
  To: Andy Shevchenko
  Cc: Lukas Bulwahn, Tzvetomir Stoyanov, Steven Rostedt,
	linux-trace-devel, Linux Kernel Mailing List



On Mon, 3 Feb 2020, Andy Shevchenko wrote:

> On Sat, Feb 1, 2020 at 6:21 PM Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote:
> >
> > The git history shows that the files under ./tools/lib/traceevent/ are
> > being developed and maintained by Tzetomir Stoyanov and Steven Rostedt
> > and are discussed on the linux-trace-devel list.
> >
> > Add a suitable section in MAINTAINERS for patches to reach them.
> >
> > This was identified with a small script that finds all files only
> > belonging to "THE REST" according to the current MAINTAINERS file, and I
> > acted upon its output.
> 
> > +TRACE EVENT LIBRARY
> > +M:     Tzvetomir Stoyanov <tz.stoyanov@gmail.com>
> > +M:     Steven Rostedt <rostedt@goodmis.org>
> > +L:     linux-trace-devel@vger.kernel.org
> > +S:     Maintained
> > +F:     tools/lib/traceevent/
> 
> Don't forget to run early mentioned scripts (in some other threads).
>

Andy, I did run on next-20200203:

$ ./scripts/checkpatch.pl -f MAINTAINERS

WARNING: MAINTAINERS entries use one tab after TYPE:
#14607: FILE: MAINTAINERS:14607:
+M:     Micah Morton <mortonm@chromium.org>

WARNING: MAINTAINERS entries use one tab after TYPE:
#14608: FILE: MAINTAINERS:14608:
+S:     Supported

WARNING: MAINTAINERS entries use one tab after TYPE:
#14609: FILE: MAINTAINERS:14609:
+F:     security/safesetid/

WARNING: MAINTAINERS entries use one tab after TYPE:
#14610: FILE: MAINTAINERS:14610:
+F:     Documentation/admin-guide/LSM/SafeSetID.rst

total: 0 errors, 4 warnings, 18577 lines checked


That issue in MAINTAINERS has a pending patch since 2019-12-07, with three 
attempts of asking to be picked up by now:

- https://lore.kernel.org/lkml/20191207182751.14249-1-lukas.bulwahn@gmail.com/
- https://lore.kernel.org/lkml/20200116185844.11201-1-lukas.bulwahn@gmail.com/
- https://lore.kernel.org/lkml/20200204040434.7173-1-lukas.bulwahn@gmail.com/

It is not related to this patch in MAINTAINERS here.


I also ran $ perl ./scripts/parse-maintainers.pl and checked the generated 
diff for this entry, but there was no reordering required; a one-element 
list of F: entries is difficult to get unsorted ;)

I am not adding any mess (ordering issues) to MAINTAINERS with this patch, 
other than what is already there, but cleaning that up is completely other 
story.

Lukas

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH RFC] MAINTAINERS: add TRACE EVENT LIBRARY section
  2020-02-04  4:41   ` Lukas Bulwahn
@ 2020-02-04 11:12     ` Andy Shevchenko
  0 siblings, 0 replies; 8+ messages in thread
From: Andy Shevchenko @ 2020-02-04 11:12 UTC (permalink / raw)
  To: Lukas Bulwahn
  Cc: Tzvetomir Stoyanov, Steven Rostedt, linux-trace-devel,
	Linux Kernel Mailing List

On Tue, Feb 4, 2020 at 6:42 AM Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote:
>
>
>
> On Mon, 3 Feb 2020, Andy Shevchenko wrote:
>
> > On Sat, Feb 1, 2020 at 6:21 PM Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote:
> > >
> > > The git history shows that the files under ./tools/lib/traceevent/ are
> > > being developed and maintained by Tzetomir Stoyanov and Steven Rostedt
> > > and are discussed on the linux-trace-devel list.
> > >
> > > Add a suitable section in MAINTAINERS for patches to reach them.
> > >
> > > This was identified with a small script that finds all files only
> > > belonging to "THE REST" according to the current MAINTAINERS file, and I
> > > acted upon its output.
> >
> > > +TRACE EVENT LIBRARY
> > > +M:     Tzvetomir Stoyanov <tz.stoyanov@gmail.com>
> > > +M:     Steven Rostedt <rostedt@goodmis.org>
> > > +L:     linux-trace-devel@vger.kernel.org
> > > +S:     Maintained
> > > +F:     tools/lib/traceevent/
> >
> > Don't forget to run early mentioned scripts (in some other threads).
> >
>
> Andy, I did run on next-20200203:

Awesome, thanks!

> $ ./scripts/checkpatch.pl -f MAINTAINERS
>
> WARNING: MAINTAINERS entries use one tab after TYPE:
> #14607: FILE: MAINTAINERS:14607:
> +M:     Micah Morton <mortonm@chromium.org>
>
> WARNING: MAINTAINERS entries use one tab after TYPE:
> #14608: FILE: MAINTAINERS:14608:
> +S:     Supported
>
> WARNING: MAINTAINERS entries use one tab after TYPE:
> #14609: FILE: MAINTAINERS:14609:
> +F:     security/safesetid/
>
> WARNING: MAINTAINERS entries use one tab after TYPE:
> #14610: FILE: MAINTAINERS:14610:
> +F:     Documentation/admin-guide/LSM/SafeSetID.rst
>
> total: 0 errors, 4 warnings, 18577 lines checked
>
>
> That issue in MAINTAINERS has a pending patch since 2019-12-07, with three
> attempts of asking to be picked up by now:
>
> - https://lore.kernel.org/lkml/20191207182751.14249-1-lukas.bulwahn@gmail.com/
> - https://lore.kernel.org/lkml/20200116185844.11201-1-lukas.bulwahn@gmail.com/
> - https://lore.kernel.org/lkml/20200204040434.7173-1-lukas.bulwahn@gmail.com/
>
> It is not related to this patch in MAINTAINERS here.
>
>
> I also ran $ perl ./scripts/parse-maintainers.pl and checked the generated
> diff for this entry, but there was no reordering required; a one-element
> list of F: entries is difficult to get unsorted ;)
>
> I am not adding any mess (ordering issues) to MAINTAINERS with this patch,
> other than what is already there, but cleaning that up is completely other
> story.

-- 
With Best Regards,
Andy Shevchenko

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH RFC] MAINTAINERS: add TRACE EVENT LIBRARY section
  2020-02-01 19:02   ` Arnaldo Carvalho de Melo
@ 2020-07-01 11:50     ` Lukas Bulwahn
  0 siblings, 0 replies; 8+ messages in thread
From: Lukas Bulwahn @ 2020-07-01 11:50 UTC (permalink / raw)
  To: Arnaldo Carvalho de Melo
  Cc: Steven Rostedt, Tzvetomir Stoyanov, linux-trace-devel,
	Linux Kernel Mailing List

On Sat, Feb 1, 2020 at 8:02 PM Arnaldo Carvalho de Melo
<arnaldo.melo@gmail.com> wrote:
>
> Em Sat, Feb 01, 2020 at 01:14:53PM -0500, Steven Rostedt escreveu:
> > On Sat,  1 Feb 2020 17:19:31 +0100
> > Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote:
> >
> > > The git history shows that the files under ./tools/lib/traceevent/ are
> > > being developed and maintained by Tzetomir Stoyanov and Steven Rostedt
> > > and are discussed on the linux-trace-devel list.
> > >
> > > Add a suitable section in MAINTAINERS for patches to reach them.
> > >
> > > This was identified with a small script that finds all files only
> > > belonging to "THE REST" according to the current MAINTAINERS file, and I
> > > acted upon its output.
> >
> > Thanks Lukas!
> >
> > Arnaldo, would you like to take this?
> >
> > Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
>
> Sure
>

Arnaldo, I think you never picked this patch and it did not make it
into mainline. I checked that the patch still applies to the current
master, so maybe you can pick it now. It is a minor non-urgent patch
and cannot break any builds :)

Thanks,

Lukas

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2020-07-01 11:50 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-01 16:19 [PATCH RFC] MAINTAINERS: add TRACE EVENT LIBRARY section Lukas Bulwahn
2020-02-01 18:14 ` Steven Rostedt
2020-02-01 19:02   ` Arnaldo Carvalho de Melo
2020-07-01 11:50     ` Lukas Bulwahn
2020-02-02  6:42 ` Tzvetomir Stoyanov
2020-02-03 10:23 ` Andy Shevchenko
2020-02-04  4:41   ` Lukas Bulwahn
2020-02-04 11:12     ` Andy Shevchenko

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).