From: Steven Rostedt <rostedt@goodmis.org>
To: "Tzvetomir Stoyanov (VMware)" <tz.stoyanov@gmail.com>
Cc: linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH v19 10/15] trace-cmd: Add guest information in host's trace.dat file
Date: Wed, 26 Feb 2020 22:56:13 -0500 [thread overview]
Message-ID: <20200226225613.08a0c7bd@oasis.local.home> (raw)
In-Reply-To: <20200131121111.130355-11-tz.stoyanov@gmail.com>
On Fri, 31 Jan 2020 14:11:06 +0200
"Tzvetomir Stoyanov (VMware)" <tz.stoyanov@gmail.com> wrote:
> +static int trace_guest_load(struct tracecmd_input *handle, char *buf, int size)
> +{
> + struct guest_trace_info *guest = NULL;
> + int cpu;
> + int i;
> +
> + guest = calloc(1, sizeof(struct guest_trace_info));
> + if (!guest)
> + goto error;
> +
> + /*
> + * Guest name, null terminated string
> + * long long (8 bytes) trace-id
> + * int (4 bytes) number of guest CPUs
> + * array of size number of guest CPUs:
> + * int (4 bytes) Guest CPU id
> + * int (4 bytes) Host PID, running the guest CPU
> + */
> +
> + guest->name = strndup(buf, size);
> + if (!guest->name)
> + goto error;
> + buf += strlen(guest->name) + 1;
> + size -= strlen(guest->name) + 1;
> +
> + if (size < sizeof(long long))
> + goto error;
> + guest->trace_id = tep_read_number(handle->pevent, buf, sizeof(long long));
> + buf += sizeof(long long);
Don't we need:
size -= sizeof(long long);
> +
> + if (size < sizeof(int))
> + goto error;
> + guest->vcpu_count = tep_read_number(handle->pevent, buf, sizeof(int));
> + buf += sizeof(int);
size -= sizeof(int);
> +
> + guest->cpu_pid = calloc(guest->vcpu_count, sizeof(int));
> + if (!guest->cpu_pid)
> + goto error;
> +
> + for (i = 0; i < guest->vcpu_count; i++) {
> + if (size < 2 * sizeof(int))
> + goto error;
> + cpu = tep_read_number(handle->pevent, buf, sizeof(int));
> + buf += sizeof(int);
> + if (cpu >= guest->vcpu_count)
> + goto error;
> + guest->cpu_pid[cpu] = tep_read_number(handle->pevent,
> + buf, sizeof(int));
> + buf += sizeof(int);
size -= 2 * sizeof(int);
-- Steve
> + }
> +
> + guest->next = handle->guest;
> + handle->guest = guest;
> + return 0;
> +
> +error:
> + if (guest) {
> + free(guest->cpu_pid);
> + free(guest->name);
> + free(guest);
> + }
> + return -1;
> +}
> +
next prev parent reply other threads:[~2020-02-27 3:56 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-31 12:10 [PATCH v19 00/15]Timestamp synchronization of host - guest tracing session Tzvetomir Stoyanov (VMware)
2020-01-31 12:10 ` [PATCH v19 01/15] trace-cmd: Add support for negative time offsets in trace.dat file Tzvetomir Stoyanov (VMware)
2020-01-31 12:10 ` [PATCH v19 02/15] trace-cmd: Add new library API for local CPU count Tzvetomir Stoyanov (VMware)
2020-01-31 12:10 ` [PATCH v19 03/15] trace-cmd: Find and store pids of tasks, which run virtual CPUs of given VM Tzvetomir Stoyanov (VMware)
2020-02-27 4:13 ` Steven Rostedt
2020-02-27 8:30 ` Tzvetomir Stoyanov
2020-01-31 12:11 ` [PATCH v19 04/15] trace-cmd: Implement new API tracecmd_add_option_v() Tzvetomir Stoyanov (VMware)
2020-01-31 12:11 ` [PATCH v19 05/15] trace-cmd: Add new API to generate a unique ID of the tracing session Tzvetomir Stoyanov (VMware)
2020-01-31 12:11 ` [PATCH v19 06/15] trace-cmd: Store the session tracing ID in the trace.dat file Tzvetomir Stoyanov (VMware)
2020-01-31 12:11 ` [PATCH v19 07/15] trace-cmd: Add definitions of htonll() and ntohll() Tzvetomir Stoyanov (VMware)
2020-01-31 12:11 ` [PATCH v19 08/15] trace-cmd: Exchange tracing IDs between host and guest Tzvetomir Stoyanov (VMware)
2020-01-31 12:11 ` [PATCH v19 09/15] trace-cmd: Implement new option in trace.dat file: TRACECMD_OPTION_TIME_SHIFT Tzvetomir Stoyanov (VMware)
2020-02-27 3:49 ` Steven Rostedt
2020-01-31 12:11 ` [PATCH v19 10/15] trace-cmd: Add guest information in host's trace.dat file Tzvetomir Stoyanov (VMware)
2020-02-27 3:53 ` Steven Rostedt
2020-02-27 3:56 ` Steven Rostedt [this message]
2020-02-27 9:39 ` Tzvetomir Stoyanov
2020-01-31 12:11 ` [PATCH v19 11/15] trace-cmd: Add host trace clock as guest trace argument Tzvetomir Stoyanov (VMware)
2020-01-31 12:11 ` [PATCH v19 12/15] trace-cmd: Refactor few trace-cmd internal functions Tzvetomir Stoyanov (VMware)
2020-01-31 12:11 ` [PATCH v19 13/15] trace-cmd: Basic infrastructure for host - guest timestamp synchronization Tzvetomir Stoyanov (VMware)
2020-01-31 12:11 ` [PATCH v19 14/15] trace-cmd: [POC] PTP-like algorithm " Tzvetomir Stoyanov (VMware)
2020-01-31 12:11 ` [PATCH v19 15/15] trace-cmd: Debug scripts for " Tzvetomir Stoyanov (VMware)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200226225613.08a0c7bd@oasis.local.home \
--to=rostedt@goodmis.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=tz.stoyanov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).