linux-trace-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 0/6] kernel-shark: Optimize the logic of the filtering menus
@ 2020-03-30 16:06 Yordan Karadzhov (VMware)
  2020-03-30 16:06 ` [PATCH v2 1/6] kernel-shark: Add method for checking if a given ID filter is set Yordan Karadzhov (VMware)
                   ` (5 more replies)
  0 siblings, 6 replies; 7+ messages in thread
From: Yordan Karadzhov (VMware) @ 2020-03-30 16:06 UTC (permalink / raw)
  To: rostedt; +Cc: linux-trace-devel, Yordan Karadzhov (VMware)

The original motivation for this change was to fix the problem that all
negative ID filters which are set using the Quick Context menu of
KernelSharlk are not visible when you open the main Filtering menus.
The logic of the main menus is optimized to use both type of filtering
and to automatically decide whether is more efficient to set positive
(show only) or negative (do not show) filter. The patch-set also includes
one very simple bug fix (patch 2/5) that was found during the development
of the new filtering logic.

v2 changes:
 - Patch [4/6] is new. It adds a simple inline method to the
   KsCheckBoxWidget class for retrieving all Ids (can be PID
   CPU Ids etc.) managed by this widget.
 - The inplementation of the new logic of the filtering menus
   is improved in order to avoid having duplicated code.


Yordan Karadzhov (VMware) (6):
  kernel-shark: Add method for checking if a given ID filter is set
  kernel-shark: Fix bug in bool kshark_export_all_cpu_filters()
  kernel-shark: Add two helper methods to KsUtils
  kernel-shark: Add getIds() to class KsCheckBoxWidget
  kernel-shark: Remove unused methods from KsMainWindow class
  kernel-shark: Optimize the logic of the filtering menus

 kernel-shark/src/KsCaptureDialog.cpp  |   6 +-
 kernel-shark/src/KsMainWindow.cpp     | 248 +++++++++++++-------------
 kernel-shark/src/KsMainWindow.hpp     |  13 +-
 kernel-shark/src/KsUtils.cpp          |  38 ++++
 kernel-shark/src/KsUtils.hpp          |   4 +
 kernel-shark/src/KsWidgetsLib.hpp     |   6 +
 kernel-shark/src/libkshark-configio.c |  17 +-
 kernel-shark/src/libkshark.c          |  21 ++-
 kernel-shark/src/libkshark.h          |   2 +
 9 files changed, 208 insertions(+), 147 deletions(-)

-- 
2.20.1


^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2020-03-30 16:07 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-30 16:06 [PATCH v2 0/6] kernel-shark: Optimize the logic of the filtering menus Yordan Karadzhov (VMware)
2020-03-30 16:06 ` [PATCH v2 1/6] kernel-shark: Add method for checking if a given ID filter is set Yordan Karadzhov (VMware)
2020-03-30 16:06 ` [PATCH v2 2/6] kernel-shark: Fix bug in bool kshark_export_all_cpu_filters() Yordan Karadzhov (VMware)
2020-03-30 16:06 ` [PATCH v2 3/6] kernel-shark: Add two helper methods to KsUtils Yordan Karadzhov (VMware)
2020-03-30 16:06 ` [PATCH v2 4/6] kernel-shark: Add getIds() to class KsCheckBoxWidget Yordan Karadzhov (VMware)
2020-03-30 16:06 ` [PATCH v2 5/6] kernel-shark: Remove unused methods from KsMainWindow class Yordan Karadzhov (VMware)
2020-03-30 16:06 ` [PATCH v2 6/6] kernel-shark: Optimize the logic of the filtering menus Yordan Karadzhov (VMware)

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).