From: Steven Rostedt <rostedt@goodmis.org>
To: "Yordan Karadzhov (VMware)" <y.karadz@gmail.com>
Cc: linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH v2 3/3] kernel-shark: Make the "stop search" button always visible
Date: Mon, 4 May 2020 14:58:02 -0400 [thread overview]
Message-ID: <20200504145802.5bb2e0c6@gandalf.local.home> (raw)
In-Reply-To: <20200504174342.24615-4-y.karadz@gmail.com>
On Mon, 4 May 2020 20:43:42 +0300
"Yordan Karadzhov (VMware)" <y.karadz@gmail.com> wrote:
> So far the button was showing up only when we do a single-threaded
> search in the data. Stopping the multi-threaded searches became
> possible after the modification of the parallel search introduced
> in the previous commit. When the multi-threaded search is restarted
> (after being stopped) the label showing the number of matches found
> is reset to show nothing. It will show the count again when the
> search finishes or is stopped.
>
I'm pulling in this series. But more of an FYI, it's best to avoid
statements like "previous commit" because when developing with git, it may
not be a previous commit, when it goes into a tree. Especially if a commit
gets cherry-picked.
Instead, use phrases like "With the parallel search changes that
were made, it is now possible to stop the multi-threaded searches and still
be at the correct percentage of the search that is displayed to the user".
It is frowned upon to mention "this commit" or "last commit" in change
logs. I catch myself doing it once in a while, and try to conform as
well ;-)
-- Steve
prev parent reply other threads:[~2020-05-04 18:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-04 17:43 [PATCH v2 0/3] kernel-shark: Have "stop" button for multi-threaded searches Yordan Karadzhov (VMware)
2020-05-04 17:43 ` [PATCH v2 1/3] kernel-shark: Simplify the search methods in class KsTraceViewer Yordan Karadzhov (VMware)
2020-05-04 18:49 ` Steven Rostedt
2020-05-04 17:43 ` [PATCH v2 2/3] kernel-shark: Change the mechanism of the multi-threaded search Yordan Karadzhov (VMware)
2020-05-04 17:43 ` [PATCH v2 3/3] kernel-shark: Make the "stop search" button always visible Yordan Karadzhov (VMware)
2020-05-04 18:58 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200504145802.5bb2e0c6@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=y.karadz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).