From: Steven Rostedt <rostedt@goodmis.org>
To: "Yordan Karadzhov (VMware)" <y.karadz@gmail.com>
Cc: linux-trace-devel@vger.kernel.org, julia.lawall@inria.fr
Subject: Re: [PATCH 2/2] kernel-shark: Add command line options for selecting plots to be shown
Date: Mon, 4 May 2020 15:13:35 -0400 [thread overview]
Message-ID: <20200504151335.6088dda5@gandalf.local.home> (raw)
In-Reply-To: <20200424132542.1620-3-y.karadz@gmail.com>
On Fri, 24 Apr 2020 16:25:42 +0300
"Yordan Karadzhov (VMware)" <y.karadz@gmail.com> wrote:
> Example:
> kernelshark -i mytrace.dat --cpu '1 4-7' --pid 11
Can we change this to use a comma instead of a space. Then we don't need to
worry about quotes.
kernelshark -i mytrace.dat --cpu 1,4-7
That's the common format for other unix command lines. See taskset for
instance.
-- Steve
>
> This will show CPUs: 1, 4, 5, 6, 7 and task(PID): 11.
>
> Signed-off-by: Yordan Karadzhov (VMware) <y.karadz@gmail.com>
> Suggested-by: Julia Lawall <julia.lawall@inria.fr>
> ---
> kernel-shark/src/KsUtils.cpp | 24 ++++++++++++++++++++++++
> kernel-shark/src/KsUtils.hpp | 2 ++
> kernel-shark/src/kernelshark.cpp | 32 +++++++++++++++++++++++++++++---
> 3 files changed, 55 insertions(+), 3 deletions(-)
>
>
next prev parent reply other threads:[~2020-05-04 19:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-24 13:25 [PATCH 0/2] Command line options for selecting plots Yordan Karadzhov (VMware)
2020-04-24 13:25 ` [PATCH 1/2] kernel-shark: Add methods for selecting the plots to be shown Yordan Karadzhov (VMware)
2020-04-24 13:25 ` [PATCH 2/2] kernel-shark: Add command line options for selecting " Yordan Karadzhov (VMware)
2020-05-04 19:13 ` Steven Rostedt [this message]
2020-05-04 19:17 ` Julia Lawall
2020-05-08 13:11 ` Yordan Karadzhov (VMware)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200504151335.6088dda5@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=julia.lawall@inria.fr \
--cc=linux-trace-devel@vger.kernel.org \
--cc=y.karadz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).