From: Steven Rostedt <rostedt@goodmis.org>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: "Yordan Karadzhov (VMware)" <y.karadz@gmail.com>,
Linux Trace Devel <linux-trace-devel@vger.kernel.org>
Subject: Re: [PATCH] trace-cmd: Fix build with gcc-10
Date: Sat, 9 May 2020 17:12:37 -0400 [thread overview]
Message-ID: <20200509171237.65f3b851@oasis.local.home> (raw)
In-Reply-To: <CADVatmOs5vHf4Zj5z4fCRB7GP1PjXGcsWB-s08DfTb-2kw60cw@mail.gmail.com>
On Sat, 9 May 2020 20:11:09 +0100
Sudip Mukherjee <sudipm.mukherjee@gmail.com> wrote:
> On Sat, May 9, 2020 at 7:48 PM Steven Rostedt <rostedt@goodmis.org> wrote:
> >
> > On Sat, 9 May 2020 19:30:38 +0100
> > Sudip Mukherjee <sudipm.mukherjee@gmail.com> wrote:
> > >
> > > > Thanks for the reminder, I haven't forgotten about it, just had other
> > > > things added on top of my "todo" list.
> > > >
> > > > I'll go apply this now.
> > >
> > > Thanks. And now kernelshark fails. :(
> > >
> >
> > Have you tried doing a make clean and building again? Sometimes the
> > updates leave objects in place that need to be recompiled, but the
> > dependencies may miss them.
>
> The build will be done in a new chroot every time so there is no
> chance of objects from a previous build. Just to make sure I did 'git
> clone' in a new folder and tried to build again. And it’s the same
> failure. Also did 'make clean' and built again with the same failure.
>
>
Hmm, I wonder if something like this fixes it?
-- Steve
diff --git a/kernel-shark/src/KsUtils.hpp b/kernel-shark/src/KsUtils.hpp
index f44139bb..272a27d1 100644
--- a/kernel-shark/src/KsUtils.hpp
+++ b/kernel-shark/src/KsUtils.hpp
@@ -32,7 +32,7 @@
//! @cond Doxygen_Suppress
-auto fontHeight = []()
+static auto fontHeight = []()
{
QFont font;
QFontMetrics fm(font);
@@ -40,7 +40,7 @@ auto fontHeight = []()
return fm.height();
};
-auto stringWidth = [](QString s)
+static auto stringWidth = [](QString s)
{
QFont font;
QFontMetrics fm(font);
next prev parent reply other threads:[~2020-05-09 21:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-17 20:39 [PATCH] trace-cmd: Fix build with gcc-10 Sudip Mukherjee
2020-04-20 19:43 ` Steven Rostedt
2020-04-20 19:53 ` Steven Rostedt
2020-04-20 22:37 ` Sudip Mukherjee
2020-05-08 12:46 ` Sudip Mukherjee
2020-05-08 14:11 ` Steven Rostedt
2020-05-09 18:30 ` Sudip Mukherjee
2020-05-09 18:48 ` Steven Rostedt
2020-05-09 19:11 ` Sudip Mukherjee
2020-05-09 21:12 ` Steven Rostedt [this message]
2020-05-09 23:27 ` Sudip Mukherjee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200509171237.65f3b851@oasis.local.home \
--to=rostedt@goodmis.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.com \
--cc=y.karadz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).