From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 039ECC433E0 for ; Mon, 8 Jun 2020 21:42:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DA2252076A for ; Mon, 8 Jun 2020 21:42:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726705AbgFHVmj (ORCPT ); Mon, 8 Jun 2020 17:42:39 -0400 Received: from mail.kernel.org ([198.145.29.99]:46186 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726612AbgFHVmj (ORCPT ); Mon, 8 Jun 2020 17:42:39 -0400 Received: from oasis.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E34952068D; Mon, 8 Jun 2020 21:42:38 +0000 (UTC) Date: Mon, 8 Jun 2020 17:42:37 -0400 From: Steven Rostedt To: "Tzvetomir Stoyanov (VMware)" Cc: linux-trace-devel@vger.kernel.org Subject: Re: [PATCH v3 5/5] trace-cmd: Add description of "-G" option Message-ID: <20200608174237.7356c737@oasis.local.home> In-Reply-To: <20200604115140.560f4eeb@gandalf.local.home> References: <20200603121506.49992-1-tz.stoyanov@gmail.com> <20200603121506.49992-6-tz.stoyanov@gmail.com> <20200604115140.560f4eeb@gandalf.local.home> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-trace-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org On Thu, 4 Jun 2020 11:51:40 -0400 Steven Rostedt wrote: > > @@ -53,6 +53,7 @@ static struct usage_help usage_help[] = { > > " --module filter module name\n" > > " --by-comm used with --profile, merge events for related comms\n" > > " --profile enable tracing options needed for report --profile\n" > > + " -G when profiling, set soft and hard irqs as global\n" > > This should be in with the other "simple" options (those with a single > character). The long options "--foo" should always be at the end after all > simple ones. Let me add. I see why you did it this way (because it is right under the --profile), but I think it still should be with the other simple options. I'll update it. Thanks! -- Steve