From: Masami Hiramatsu <mhiramat@kernel.org>
To: Sascha Ortmann <sascha.ortmann@stud.uni-hannover.de>
Cc: linux-kernel@i4.cs.fau.de, linux-kernel@vger.kernel.org,
linux-trace-devel@vger.kernel.org, maximilian.werner96@gmail.com,
mingo@redhat.com, rostedt@goodmis.org
Subject: Re: [PATCH v2] tracing/boottime: Fix kprobe multiple events
Date: Fri, 19 Jun 2020 10:58:27 +0900 [thread overview]
Message-ID: <20200619105827.c6042e60cdcd8609f5ec79e4@kernel.org> (raw)
In-Reply-To: <20200618163301.25854-1-sascha.ortmann@stud.uni-hannover.de>
On Thu, 18 Jun 2020 18:33:01 +0200
Sascha Ortmann <sascha.ortmann@stud.uni-hannover.de> wrote:
> Fix boottime kprobe events to report and abort after each failure when
> adding probes.
>
> As an example, when we try to set multiprobe kprobe events in
> bootconfig like this:
>
> ftrace.event.kprobes.vfsevents {
> probes = "vfs_read $arg1 $arg2,,
> !error! not reported;?", // leads to error
> "vfs_write $arg1 $arg2"
> }
>
> This will not work as expected. After
> commit da0f1f4167e3af69e ("tracing/boottime: Fix kprobe event API usage"),
> the function trace_boot_add_kprobe_event will not produce any error
> message when adding a probe fails at kprobe_event_gen_cmd_start.
> Furthermore, we continue to add probes when kprobe_event_gen_cmd_end fails
> (and kprobe_event_gen_cmd_start did not fail). In this case the function
> even returns successfully when the last call to kprobe_event_gen_cmd_end
> is successful.
>
> The behaviour of reporting and aborting after failures is not
> consistent.
>
> The function trace_boot_add_kprobe_event now reports each failure and
> stops adding probes immediately.
Thanks for updating. This looks good to me.
Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
and
Fixes: da0f1f4167e3 ("tracing/boottime: Fix kprobe event API usage")
Thank you!
>
> Cc: linux-kernel@i4.cs.fau.de
> Co-developed-by: Maximilian Werner <maximilian.werner96@gmail.com>
> Signed-off-by: Maximilian Werner <maximilian.werner96@gmail.com>
> Signed-off-by: Sascha Ortmann <sascha.ortmann@stud.uni-hannover.de>
> ---
> kernel/trace/trace_boot.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/trace/trace_boot.c b/kernel/trace/trace_boot.c
> index 9de29bb45a27..be893eb22071 100644
> --- a/kernel/trace/trace_boot.c
> +++ b/kernel/trace/trace_boot.c
> @@ -101,12 +101,16 @@ trace_boot_add_kprobe_event(struct xbc_node *node, const char *event)
> kprobe_event_cmd_init(&cmd, buf, MAX_BUF_LEN);
>
> ret = kprobe_event_gen_cmd_start(&cmd, event, val);
> - if (ret)
> + if (ret) {
> + pr_err("Failed to generate probe: %s\n", buf);
> break;
> + }
>
> ret = kprobe_event_gen_cmd_end(&cmd);
> - if (ret)
> + if (ret) {
> pr_err("Failed to add probe: %s\n", buf);
> + break;
> + }
> }
>
> return ret;
> --
> 2.17.1
>
--
Masami Hiramatsu <mhiramat@kernel.org>
prev parent reply other threads:[~2020-06-19 1:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-17 14:08 [PATCH] tracing/boottime: Fix kprobe multiple events Sascha Ortmann
2020-06-17 15:05 ` Steven Rostedt
2020-06-17 15:06 ` Steven Rostedt
2020-06-17 15:57 ` Maximilian Werner
2020-06-17 16:06 ` Steven Rostedt
2020-06-18 1:50 ` Masami Hiramatsu
2020-06-18 16:33 ` [PATCH v2] " Sascha Ortmann
2020-06-19 1:58 ` Masami Hiramatsu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200619105827.c6042e60cdcd8609f5ec79e4@kernel.org \
--to=mhiramat@kernel.org \
--cc=linux-kernel@i4.cs.fau.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=maximilian.werner96@gmail.com \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=sascha.ortmann@stud.uni-hannover.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).