From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B3C6C433EA for ; Tue, 14 Jul 2020 14:25:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ECED121D7A for ; Tue, 14 Jul 2020 14:25:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728552AbgGNOZn (ORCPT ); Tue, 14 Jul 2020 10:25:43 -0400 Received: from mail.kernel.org ([198.145.29.99]:49116 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728530AbgGNOZn (ORCPT ); Tue, 14 Jul 2020 10:25:43 -0400 Received: from oasis.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C94A521D7A; Tue, 14 Jul 2020 14:25:42 +0000 (UTC) Date: Tue, 14 Jul 2020 10:25:41 -0400 From: Steven Rostedt To: Tzvetomir Stoyanov Cc: Namhyung Kim , Linux Trace Devel Subject: Re: [PATCH 0/8] Few libtraceeevnt fixes, suggested Namhyung Kim Message-ID: <20200714102541.7dc27838@oasis.local.home> In-Reply-To: References: <20200714103027.2477584-1-tz.stoyanov@gmail.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-trace-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org On Tue, 14 Jul 2020 15:12:10 +0300 Tzvetomir Stoyanov wrote: > On Tue, Jul 14, 2020 at 3:07 PM Namhyung Kim wrote: > > > > Hello, > > > > On Tue, Jul 14, 2020 at 7:30 PM Tzvetomir Stoyanov (VMware) > > wrote: > > > > > > Fixes in libtraceeevnt, suggested by Namhyung Kim > > > > > > Tzvetomir Stoyanov (VMware) (8): > > > trace-cmd: Document tep_load_plugins_hook() > > > trace-cmd: Handle strdup() error in parse_option_name() > > > trace-cmd: Fix typo in tep_plugin_add_option() description > > > trace-cmd: Improve error handling of tep_plugin_add_option() API > > > trace-cmd: Fixed broken indentation in parse_ip4_print_args() > > > trace-cmd: Fixed type in PRINT_FMT_STING > > > trace-cmd: Fixed description of tep_add_plugin_path() API > > > trace-cmd: Handle possible strdup() error in tep_add_plugin_path() API > > > > Shouldn't the prefix be libtraceevent ? Other than that, > > I decided to address the comments in trace-cmd repo first, and after > that to backport the patches to the kernel's libtraceevent. That's why > the prefix is trace-cmd. Actually, even in the trace-cmd repo, they should be labeled libtraceveent, as they are specific for the libtraceevent portion of trace-cmd.git. Otherwise everything in the repo would be trace-cmd: ;-) I've tried to separate out different parts. Anything labeled trace-cmd: should be for something unique to the trace-cmd executable. If something is for libtracefs, it should be libtracefs: or tracefs:. If it is for libtracevent, then that should be libtracevent: or traceevent: -- Steve