From: Vitaly Chikunov <vt@altlinux.org>
To: Steven Rostedt <rostedt@goodmis.org>, linux-trace-devel@vger.kernel.org
Cc: Vitaly Chikunov <vt@altlinux.org>, "Dmitry V . Levin" <ldv@altlinux.org>
Subject: [PATCH 2/2] Makefile: Fix build of utest on systems with --as-needed enabled
Date: Mon, 20 Jul 2020 19:44:53 +0300 [thread overview]
Message-ID: <20200720164453.5161-2-vt@altlinux.org> (raw)
In-Reply-To: <20200720164453.5161-1-vt@altlinux.org>
On systems (such as ALT Linux) where `--as-needed' is passed to ld by
default, building tests fail due to CUNIT_INSTALLED test failure to link
with libcunit, becasue `-lcunit' is passed before input file (which is
`-'). Move `-lcunit' after '-' to link it properly.
To reproduce `make CC='gcc -Wl,--as-needed' test`. Error message:
Makefile:344: *** CUnit framework not installed, cannot build unit tests. Stop.
Signed-off-by: Vitaly Chikunov <vt@altlinux.org>
Cc: Dmitry V. Levin <ldv@altlinux.org>
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index 6b606da..83e5646 100644
--- a/Makefile
+++ b/Makefile
@@ -242,7 +242,7 @@ ifeq ($(VSOCK_DEFINED), 1)
CFLAGS += -DVSOCK
endif
-CUNIT_INSTALLED := $(shell if (printf "$(pound)include <CUnit/Basic.h>\n void main(){CU_initialize_registry();}" | $(CC) -x c -lcunit - >/dev/null 2>&1) ; then echo 1; else echo 0 ; fi)
+CUNIT_INSTALLED := $(shell if (printf "$(pound)include <CUnit/Basic.h>\n void main(){CU_initialize_registry();}" | $(CC) -x c - -lcunit >/dev/null 2>&1) ; then echo 1; else echo 0 ; fi)
export CUNIT_INSTALLED
export CFLAGS
--
2.11.0
next prev parent reply other threads:[~2020-07-20 16:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-20 16:44 [PATCH 1/2] Makefile: Fix CUNIT_INSTALLED test to work with make 4.3 and dash Vitaly Chikunov
2020-07-20 16:44 ` Vitaly Chikunov [this message]
2020-07-22 21:58 ` [PATCH 2/2] Makefile: Fix build of utest on systems with --as-needed enabled Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200720164453.5161-2-vt@altlinux.org \
--to=vt@altlinux.org \
--cc=ldv@altlinux.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).