From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3776C4363D for ; Thu, 1 Oct 2020 01:33:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 81AA0207F7 for ; Thu, 1 Oct 2020 01:33:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601516032; bh=Q+vG1Iy21aKO3fd+yyNZHmqOXFf/RkCShrguzNHr/T4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=jWlLM8W80XYrU7Pr1oarBcagK6hB36zUqiBAGWeZSJgsA47jSFnr/HoiF8dEj2S43 h+tlX/ZdFBwHS6ugT52vNi8NniYVduNAAIIPyKORqd4uriyn/TgBwupQxnfJF39Vr9 DLI8oAF8ugWYT7Y+IwDzjUJUBOBGRnzptCL8WZs0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728660AbgJABdw (ORCPT ); Wed, 30 Sep 2020 21:33:52 -0400 Received: from mail.kernel.org ([198.145.29.99]:36314 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725800AbgJABdv (ORCPT ); Wed, 30 Sep 2020 21:33:51 -0400 Received: from quaco.ghostprotocols.net (unknown [179.97.37.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7060C20738; Thu, 1 Oct 2020 01:33:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601516031; bh=Q+vG1Iy21aKO3fd+yyNZHmqOXFf/RkCShrguzNHr/T4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=s2FxZZmJseOUOR07A+317HsKMHMvskrKF9SXzq9Z+uFGE4Yo7icDsz1oxpG+zVoCg uk2x+JIz+1j0G7nj8kwjlm5AU9vr6KSsjSxZgix6mSb/X/3ZEmD0ZwqwHXovKQkKbS iyXvnYlIpTsSUhqXx3P3H57qr1yakdRNAqjZzJrA= Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 554BF400E9; Wed, 30 Sep 2020 22:33:49 -0300 (-03) Date: Wed, 30 Sep 2020 22:33:49 -0300 From: Arnaldo Carvalho de Melo To: Steven Rostedt Cc: "Tzvetomir Stoyanov (VMware)" , arnaldo.melo@gmail.com, linux-trace-devel@vger.kernel.org, ben@decadent.org.uk, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4] tools lib traceevent: Hide non API functions Message-ID: <20201001013349.GB3169811@kernel.org> References: <20200930110733.280534-1-tz.stoyanov@gmail.com> <20200930125027.7e54b71c@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200930125027.7e54b71c@gandalf.local.home> X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org Em Wed, Sep 30, 2020 at 12:50:27PM -0400, Steven Rostedt escreveu: > On Wed, 30 Sep 2020 14:07:33 +0300 > "Tzvetomir Stoyanov (VMware)" wrote: > > > There are internal library functions, which are not declared as a static. > > They are used inside the library from different files. Hide them from > > the library users, as they are not part of the API. > > These functions are made hidden and are renamed without the prefix "tep_": > > tep_free_plugin_paths > > tep_peek_char > > tep_buffer_init > > tep_get_input_buf_ptr > > tep_get_input_buf > > tep_read_token > > tep_free_token > > tep_free_event > > tep_free_format_field > > __tep_parse_format > > > > Link: https://lore.kernel.org/linux-trace-devel/e4afdd82deb5e023d53231bb13e08dca78085fb0.camel@decadent.org.uk/ > > Reported-by: Ben Hutchings > > Signed-off-by: Tzvetomir Stoyanov (VMware) > > --- > > Reviewed-by: Steven Rostedt (VMware) > > Arnaldo, > > Can you pull this in? Sure, I was just waiting for this to get to some conclusion. - Arnaldo