From: Steven Rostedt <rostedt@goodmis.org>
To: linux-trace-devel@vger.kernel.org
Subject: [PATCH 2/2] libtracevent: Remove tempfile libtraceevent.pc
Date: Mon, 23 Nov 2020 13:48:43 -0500 [thread overview]
Message-ID: <20201123184940.031517790@goodmis.org> (raw)
In-Reply-To: 20201123184841.548901150@goodmis.org
From: "Steven Rostedt (VMware)" <rostedt@goodmis.org>
"make install" copies libtraceevent.pc.template to libtraceevent.pc and then
modifies it for the installation. This command is usually executed as root,
and when finished, it leaves behind the libtraceevent.pc file owned by root.
Have the "make install" clean up and remove the temporary libtraceevent.pc
file, so that root owned files do not get left behind.
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
---
Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/Makefile b/Makefile
index 2a6bfcce814f..775fbd2b3f0e 100644
--- a/Makefile
+++ b/Makefile
@@ -218,6 +218,7 @@ define do_install_pkgconfig_file
sed -i "s|LIB_DIR|${libdir}|g" ${PKG_CONFIG_FILE}; \
sed -i "s|HEADER_DIR|$(includedir)|g" ${PKG_CONFIG_FILE}; \
$(call do_install,$(PKG_CONFIG_FILE),$(pkgconfig_dir),644); \
+ ${RM} ${PKG_CONFIG_FILE}; \
else \
(echo Failed to locate pkg-config directory) 1>&2; \
fi
--
2.28.0
next prev parent reply other threads:[~2020-11-23 18:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-23 18:48 [PATCH 0/2] libtraceevent: Some Makefile updates Steven Rostedt
2020-11-23 18:48 ` [PATCH 1/2] libtraceevent: Add libtraceevent.so.$(EP_VERSION) to targets and fix links Steven Rostedt
2020-11-24 5:10 ` Tzvetomir Stoyanov
2020-11-23 18:48 ` Steven Rostedt [this message]
2020-11-24 5:26 ` [PATCH 2/2] libtracevent: Remove tempfile libtraceevent.pc Tzvetomir Stoyanov
2020-11-24 13:51 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201123184940.031517790@goodmis.org \
--to=rostedt@goodmis.org \
--cc=linux-trace-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).