linux-trace-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: David Runge <dave@sleepmap.de>
Cc: "Yordan Karadzhov (VMware)" <y.karadz@gmail.com>,
	linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH v6 00/27] Start KernelShark v2 transformation
Date: Thu, 10 Dec 2020 09:42:50 -0500	[thread overview]
Message-ID: <20201210094250.49674c33@gandalf.local.home> (raw)
In-Reply-To: <X9Hgwhhc5hbhLsFV@hmbx>

On Thu, 10 Dec 2020 09:48:02 +0100
David Runge <dave@sleepmap.de> wrote:

> On 2020-12-09 21:38:22 (-0500), Steven Rostedt wrote:
> > On Wed,  9 Dec 2020 15:41:36 +0200
> > "Yordan Karadzhov (VMware)" <y.karadz@gmail.com> wrote:
> > I just realized that the current repo doesn't build against the latest
> > libtracefs, because the library's location has moved.  I noticed that
> > the CMake files have it hard coded with:
> > 
> >  find_library(TRACEFS_LIBRARY    NAMES  tracefs/libtracefs.a
> >  find_library(TRACEFS_LIBRARY    NAMES  tracefs/libtracefs.so)
> > 
> > Is there a way to make cmake use pkg-config?
> > 
> > 	pkg-config --cflags --libs libtracefs
> > 
> > Will give us the correct includes and libraries for building against
> > libtracefs if installed.
> > 
> > We'll want the same for libtraceevent and libtracecmd as well.  
> 
> find_package() [1] is usually used for package discovery in cmake-land.
> If the NAMES argument is provided it overrides any provided package
> name.
> In more complex cases (of the package) it is better to have the
> package ship with a find_<PACKAGE>.cmake file that will be automatically
> used by cmake if it is installed in the system locations.
> 
> To use pkg-config/pkgconf directly, it is possible to make use of
> the FindPkgConfig [2] module.
> 

Yeah, that FindPkgConfig module looks like what we need.

> Best,
> David
> 
> P.S.: Out of context: Why is the cmake minimum requirement so low? To
> make use of useful features in cmake it needs to be at least 3.4, better
> higher even.

Note, I've never used cmake before Yordan introduced it to KernelShark. This
question is better answered by Yordan.

-- Steve


> 
> [1] https://cmake.org/cmake/help/latest/command/find_package.html#command:find_package
> [2] https://cmake.org/cmake/help/latest/module/FindPkgConfig.html
> 


      parent reply	other threads:[~2020-12-10 14:43 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-09 13:41 [PATCH v6 00/27] Start KernelShark v2 transformation Yordan Karadzhov (VMware)
2020-12-09 13:41 ` [PATCH v6 01/27] kernel-shark: Use only signed types in kshark_entry Yordan Karadzhov (VMware)
2020-12-09 13:41 ` [PATCH v6 02/27] kernel-shark: Add stream_id to kshark_entry Yordan Karadzhov (VMware)
2020-12-09 13:41 ` [PATCH v6 03/27] kernel-shark: Introduce libkshark-hash Yordan Karadzhov (VMware)
2020-12-09 13:41 ` [PATCH v6 04/27] kernel-shark: Introduce Data streams Yordan Karadzhov (VMware)
2020-12-09 13:41 ` [PATCH v6 05/27] kernel-shark: Rename static methods in libkshark Yordan Karadzhov (VMware)
2020-12-09 13:41 ` [PATCH v6 06/27] kernel-shark: Add basic methods for Data streams Yordan Karadzhov (VMware)
2020-12-09 13:41 ` [PATCH v6 07/27] kernel-shark: Housekeeping before implementing stream interface Yordan Karadzhov (VMware)
2020-12-09 13:41 ` [PATCH v6 08/27] kernel-shark: Add stream interface for trace-cmd data Yordan Karadzhov (VMware)
2020-12-09 13:41 ` [PATCH v6 09/27] kernel-shark: Start introducing KernelShark 2.0 Yordan Karadzhov (VMware)
2020-12-09 13:41 ` [PATCH v6 10/27] kernel-shark: Start using data streams Yordan Karadzhov (VMware)
2020-12-09 13:41 ` [PATCH v6 11/27] kernel-shark: Remove dead code Yordan Karadzhov (VMware)
2020-12-09 13:41 ` [PATCH v6 12/27] kernel-shark: Redesign the plugin interface Yordan Karadzhov (VMware)
2020-12-09 13:41 ` [PATCH v6 13/27] kernel-shark: Complete the stream integration Yordan Karadzhov (VMware)
2020-12-09 13:41 ` [PATCH v6 14/27] kernel-shark: Provide merging of multiple data streams Yordan Karadzhov (VMware)
2020-12-09 13:41 ` [PATCH v6 15/27] kernel-shark: Integrate the stream definitions with data model Yordan Karadzhov (VMware)
2020-12-09 13:41 ` [PATCH v6 16/27] kernel-shark: Use only signed types for model defs Yordan Karadzhov (VMware)
2020-12-09 13:41 ` [PATCH v6 17/27] kernel-shark: Add ksmodel_get_bin() Yordan Karadzhov (VMware)
2020-12-09 13:41 ` [PATCH v6 18/27] kernel-shark: Protect ksmodel_set_in_range_bining() Yordan Karadzhov (VMware)
2020-12-09 13:41 ` [PATCH v6 19/27] kernel-shark: Add methods for time calibration Yordan Karadzhov (VMware)
2020-12-09 13:41 ` [PATCH v6 20/27] kernel-shark: Integrate streams with libkshark-configio Yordan Karadzhov (VMware)
2020-12-09 13:41 ` [PATCH v6 21/27] kernel-shark: Add support for drawing text Yordan Karadzhov (VMware)
2020-12-09 13:41 ` [PATCH v6 22/27] kernel-shark: Make GLUT optional dependency Yordan Karadzhov (VMware)
2020-12-09 13:41 ` [PATCH v6 23/27] kernel-shark: Add ksplot_draw_polyline() Yordan Karadzhov (VMware)
2020-12-09 13:42 ` [PATCH v6 24/27] kernel-shark: Optimize ksplot_draw_polygon() Yordan Karadzhov (VMware)
2020-12-09 13:42 ` [PATCH v6 25/27] kernel-shark: Do not use the ARRAY_SIZE macro Yordan Karadzhov (VMware)
2020-12-09 13:42 ` [PATCH v6 26/27] kernel-shark: Add basic infrastructure for testing Yordan Karadzhov (VMware)
2020-12-09 13:42 ` [PATCH v6 27/27] kernel-shark: Add "github Actions" workflow Yordan Karadzhov (VMware)
2020-12-10  2:38 ` [PATCH v6 00/27] Start KernelShark v2 transformation Steven Rostedt
2020-12-10  8:48   ` David Runge
2020-12-10 14:38     ` Yordan Karadzhov (VMware)
2020-12-10 14:42     ` Steven Rostedt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201210094250.49674c33@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=dave@sleepmap.de \
    --cc=linux-trace-devel@vger.kernel.org \
    --cc=y.karadz@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).