Re: [PATCH] trace-cmd: Fix lib audit warning message

[Steven Rostedt <rostedt@goodmis.org>]

On Tue, 12 Jan 2021 13:01:20 +0530
Sameeruddin Shaik <sameeruddin.shaik8@gmail.com> wrote:

Hi Sameer,

> statically updated the warning message which we will get, when
> compiling trace-cmd without the libaudit library.
> 
> Following are the the messages which will pop out when compiling
> 
> Before:
> -------
> trace-profile.c:23:3: warning: #warning "lib audit not found, using
> raw syscalls " "(install libaudit-devel and try again)"
> 
> After:
> -------
> trace-profile.c:23:3: warning: #warning "lib audit not found, using
> raw syscalls " "(install libaudit-devel(for fedora) or
> libaudit-dev(for debian/ubuntu) and try again)"
> 
> Signed-off-by: Sameeruddin shaik <sameeruddin.shaik8@gmail.com>
> ---
>  tracecmd/trace-profile.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tracecmd/trace-profile.c b/tracecmd/trace-profile.c
> index cfae2a2..4e5d68d 100644
> --- a/tracecmd/trace-profile.c
> +++ b/tracecmd/trace-profile.c
> @@ -21,7 +21,8 @@
> 
>  #ifdef WARN_NO_AUDIT
>  # warning "lib audit not found, using raw syscalls "    \

Your mail client turned tabs into spaces and this doesn't apply properly.
Are you able to fix that?

> -    "(install libaudit-devel and try again)"
> +    "(install libaudit-devel(for fedora) or libaudit-dev(for \
> +debian/ubuntu) and try again)"

Also, the above can stay on one line. Yes, it breaks the 80 char limit, but
that's more of a guideline and not a requirement ;-)


Care to send a v2?

Thanks!

-- Steve

>  #endif
> 
>  #define TASK_STATE_TO_CHAR_STR "RSDTtXZxKWP"