Linux-Trace-Devel Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] trace-cmd: Fix lib audit warning message
@ 2021-01-12  7:31 Sameeruddin Shaik
  2021-01-12 17:29 ` Steven Rostedt
  0 siblings, 1 reply; 6+ messages in thread
From: Sameeruddin Shaik @ 2021-01-12  7:31 UTC (permalink / raw)
  To: linux-trace-devel

statically updated the warning message which we will get, when
compiling trace-cmd without the libaudit library.

Following are the the messages which will pop out when compiling

Before:
-------
trace-profile.c:23:3: warning: #warning "lib audit not found, using
raw syscalls " "(install libaudit-devel and try again)"

After:
-------
trace-profile.c:23:3: warning: #warning "lib audit not found, using
raw syscalls " "(install libaudit-devel(for fedora) or
libaudit-dev(for debian/ubuntu) and try again)"

Signed-off-by: Sameeruddin shaik <sameeruddin.shaik8@gmail.com>
---
 tracecmd/trace-profile.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tracecmd/trace-profile.c b/tracecmd/trace-profile.c
index cfae2a2..4e5d68d 100644
--- a/tracecmd/trace-profile.c
+++ b/tracecmd/trace-profile.c
@@ -21,7 +21,8 @@

 #ifdef WARN_NO_AUDIT
 # warning "lib audit not found, using raw syscalls "    \
-    "(install libaudit-devel and try again)"
+    "(install libaudit-devel(for fedora) or libaudit-dev(for \
+debian/ubuntu) and try again)"
 #endif

 #define TASK_STATE_TO_CHAR_STR "RSDTtXZxKWP"
-- 
2.7.4

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] trace-cmd: Fix lib audit warning message
  2021-01-12  7:31 [PATCH] trace-cmd: Fix lib audit warning message Sameeruddin Shaik
@ 2021-01-12 17:29 ` Steven Rostedt
  2021-01-13 16:10   ` sameeruddin shaik
  0 siblings, 1 reply; 6+ messages in thread
From: Steven Rostedt @ 2021-01-12 17:29 UTC (permalink / raw)
  To: Sameeruddin Shaik; +Cc: linux-trace-devel

On Tue, 12 Jan 2021 13:01:20 +0530
Sameeruddin Shaik <sameeruddin.shaik8@gmail.com> wrote:

Hi Sameer,

> statically updated the warning message which we will get, when
> compiling trace-cmd without the libaudit library.
> 
> Following are the the messages which will pop out when compiling
> 
> Before:
> -------
> trace-profile.c:23:3: warning: #warning "lib audit not found, using
> raw syscalls " "(install libaudit-devel and try again)"
> 
> After:
> -------
> trace-profile.c:23:3: warning: #warning "lib audit not found, using
> raw syscalls " "(install libaudit-devel(for fedora) or
> libaudit-dev(for debian/ubuntu) and try again)"
> 
> Signed-off-by: Sameeruddin shaik <sameeruddin.shaik8@gmail.com>
> ---
>  tracecmd/trace-profile.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tracecmd/trace-profile.c b/tracecmd/trace-profile.c
> index cfae2a2..4e5d68d 100644
> --- a/tracecmd/trace-profile.c
> +++ b/tracecmd/trace-profile.c
> @@ -21,7 +21,8 @@
> 
>  #ifdef WARN_NO_AUDIT
>  # warning "lib audit not found, using raw syscalls "    \

Your mail client turned tabs into spaces and this doesn't apply properly.
Are you able to fix that?

> -    "(install libaudit-devel and try again)"
> +    "(install libaudit-devel(for fedora) or libaudit-dev(for \
> +debian/ubuntu) and try again)"

Also, the above can stay on one line. Yes, it breaks the 80 char limit, but
that's more of a guideline and not a requirement ;-)


Care to send a v2?

Thanks!

-- Steve

>  #endif
> 
>  #define TASK_STATE_TO_CHAR_STR "RSDTtXZxKWP"


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] trace-cmd: Fix lib audit warning message
  2021-01-13 16:10   ` sameeruddin shaik
@ 2021-01-13 14:38     ` Steven Rostedt
  0 siblings, 0 replies; 6+ messages in thread
From: Steven Rostedt @ 2021-01-13 14:38 UTC (permalink / raw)
  To: sameeruddin shaik; +Cc: linux-trace-devel

On Wed, 13 Jan 2021 21:40:45 +0530
sameeruddin shaik <sameeruddin.shaik8@gmail.com> wrote:

> hi steve,
> 
> please check now.
> 

No, unfortunately its still corrupted. Can you try sending with git?

 https://coderwall.com/p/qcsiew/setting-up-and-using-git-send-email-with-gmail

-- Steve

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] trace-cmd: Fix lib audit warning message
  2021-01-12 17:29 ` Steven Rostedt
@ 2021-01-13 16:10   ` sameeruddin shaik
  2021-01-13 14:38     ` Steven Rostedt
  0 siblings, 1 reply; 6+ messages in thread
From: sameeruddin shaik @ 2021-01-13 16:10 UTC (permalink / raw)
  To: Steven Rostedt; +Cc: linux-trace-devel

hi steve,

please check now.

statically updated the warning message which we will get, when
compiling trace-cmd without the libaudit library.

Following are the the messages which will pop out when compiling

Before:
-------
trace-profile.c:23:3: warning: #warning "lib audit not found, using raw 
syscalls " "(install libaudit-devel and try again)"

After:
-------
trace-profile.c:23:3: warning: #warning "lib audit not found, using raw 
syscalls " "(install libaudit-devel(for fedora) or libaudit-dev(for 
debian/ubuntu) and try again)"

Signed-off-by: Sameeruddin shaik <sameeruddin.shaik8@gmail.com>
---
  tracecmd/trace-profile.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tracecmd/trace-profile.c b/tracecmd/trace-profile.c
index cfae2a2..9b5c385 100644
--- a/tracecmd/trace-profile.c
+++ b/tracecmd/trace-profile.c
@@ -21,7 +21,7 @@

  #ifdef WARN_NO_AUDIT
  # warning "lib audit not found, using raw syscalls "    \
-    "(install libaudit-devel and try again)"
+    "(install libaudit-devel(for fedora) or libaudit-dev(for 
debian/ubuntu) and try again)"
  #endif

  #define TASK_STATE_TO_CHAR_STR "RSDTtXZxKWP"
-- 

Thanks,

sameer.

On 12/01/21 10:59 pm, Steven Rostedt wrote:
> On Tue, 12 Jan 2021 13:01:20 +0530
> Sameeruddin Shaik <sameeruddin.shaik8@gmail.com> wrote:
>
> Hi Sameer,
>
>> statically updated the warning message which we will get, when
>> compiling trace-cmd without the libaudit library.
>>
>> Following are the the messages which will pop out when compiling
>>
>> Before:
>> -------
>> trace-profile.c:23:3: warning: #warning "lib audit not found, using
>> raw syscalls " "(install libaudit-devel and try again)"
>>
>> After:
>> -------
>> trace-profile.c:23:3: warning: #warning "lib audit not found, using
>> raw syscalls " "(install libaudit-devel(for fedora) or
>> libaudit-dev(for debian/ubuntu) and try again)"
>>
>> Signed-off-by: Sameeruddin shaik <sameeruddin.shaik8@gmail.com>
>> ---
>>   tracecmd/trace-profile.c | 3 ++-
>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/tracecmd/trace-profile.c b/tracecmd/trace-profile.c
>> index cfae2a2..4e5d68d 100644
>> --- a/tracecmd/trace-profile.c
>> +++ b/tracecmd/trace-profile.c
>> @@ -21,7 +21,8 @@
>>
>>   #ifdef WARN_NO_AUDIT
>>   # warning "lib audit not found, using raw syscalls "    \
> Your mail client turned tabs into spaces and this doesn't apply properly.
> Are you able to fix that?
>
>> -    "(install libaudit-devel and try again)"
>> +    "(install libaudit-devel(for fedora) or libaudit-dev(for \
>> +debian/ubuntu) and try again)"
> Also, the above can stay on one line. Yes, it breaks the 80 char limit, but
> that's more of a guideline and not a requirement ;-)
>
>
> Care to send a v2?
>
> Thanks!
>
> -- Steve
>
>>   #endif
>>
>>   #define TASK_STATE_TO_CHAR_STR "RSDTtXZxKWP"

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH] trace-cmd: Fix lib audit warning message
@ 2021-01-14  6:44 Sameeruddin shaik
  2021-01-14  2:04 ` Steven Rostedt
  0 siblings, 1 reply; 6+ messages in thread
From: Sameeruddin shaik @ 2021-01-14  6:44 UTC (permalink / raw)
  To: linux-trace-devel; +Cc: Sameeruddin shaik

statically updated the warning message which we will get, when
compiling trace-cmd without the libaudit library.

Following are the the messages which will pop out when compiling

Before:
-------
trace-profile.c:23:3: warning: #warning "lib audit not found, using raw syscalls " "(install libaudit-devel and try again)"

After:
-------
trace-profile.c:23:3: warning: #warning "lib audit not found, using raw syscalls " "(install libaudit-devel(for fedora) or libaudit-dev(for debian/ubuntu) and try again)"

Signed-off-by: Sameeruddin shaik <sameeruddin.shaik8@gmail.com>
---
 tracecmd/trace-profile.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tracecmd/trace-profile.c b/tracecmd/trace-profile.c
index cfae2a2..9b5c385 100644
--- a/tracecmd/trace-profile.c
+++ b/tracecmd/trace-profile.c
@@ -21,7 +21,7 @@
 
 #ifdef WARN_NO_AUDIT
 # warning "lib audit not found, using raw syscalls "	\
-	"(install libaudit-devel and try again)"
+	"(install libaudit-devel(for fedora) or libaudit-dev(for debian/ubuntu) and try again)"
 #endif
 
 #define TASK_STATE_TO_CHAR_STR "RSDTtXZxKWP"
-- 
2.7.4


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] trace-cmd: Fix lib audit warning message
  2021-01-14  6:44 Sameeruddin shaik
@ 2021-01-14  2:04 ` Steven Rostedt
  0 siblings, 0 replies; 6+ messages in thread
From: Steven Rostedt @ 2021-01-14  2:04 UTC (permalink / raw)
  To: Sameeruddin shaik; +Cc: linux-trace-devel

On Thu, 14 Jan 2021 12:14:48 +0530
Sameeruddin shaik <sameeruddin.shaik8@gmail.com> wrote:

Thanks Sameer!

Just FYI, this isn't that important for this patch, but just to inform
you about basic procedures (we follow the Linux kernel method). When
sending a second version of the patch, add a "v2" to the subject. That
is, "[PATCH v2] trace-cmd: Fix lib audit warning message". Then below
the Signed-off-by (after the "---") add a section of "Changes since
v1:" that gives a brief list of changes that were made in the new
version. But again, not a big deal for this one, but something to be
aware of for future patches :)

Anyway, I did a preliminary test, and it looks like you this applies
without issue. I'll add it tomorrow. Thanks!

-- Steve


> statically updated the warning message which we will get, when
> compiling trace-cmd without the libaudit library.
> 
> Following are the the messages which will pop out when compiling
> 
> Before:
> -------
> trace-profile.c:23:3: warning: #warning "lib audit not found, using raw syscalls " "(install libaudit-devel and try again)"
> 
> After:
> -------
> trace-profile.c:23:3: warning: #warning "lib audit not found, using raw syscalls " "(install libaudit-devel(for fedora) or libaudit-dev(for debian/ubuntu) and try again)"
> 
> Signed-off-by: Sameeruddin shaik <sameeruddin.shaik8@gmail.com>
> ---
>  tracecmd/trace-profile.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tracecmd/trace-profile.c b/tracecmd/trace-profile.c
> index cfae2a2..9b5c385 100644
> --- a/tracecmd/trace-profile.c
> +++ b/tracecmd/trace-profile.c
> @@ -21,7 +21,7 @@
>  
>  #ifdef WARN_NO_AUDIT
>  # warning "lib audit not found, using raw syscalls "	\
> -	"(install libaudit-devel and try again)"
> +	"(install libaudit-devel(for fedora) or libaudit-dev(for debian/ubuntu) and try again)"
>  #endif
>  
>  #define TASK_STATE_TO_CHAR_STR "RSDTtXZxKWP"


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, back to index

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-12  7:31 [PATCH] trace-cmd: Fix lib audit warning message Sameeruddin Shaik
2021-01-12 17:29 ` Steven Rostedt
2021-01-13 16:10   ` sameeruddin shaik
2021-01-13 14:38     ` Steven Rostedt
2021-01-14  6:44 Sameeruddin shaik
2021-01-14  2:04 ` Steven Rostedt

Linux-Trace-Devel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-trace-devel/0 linux-trace-devel/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-trace-devel linux-trace-devel/ https://lore.kernel.org/linux-trace-devel \
		linux-trace-devel@vger.kernel.org
	public-inbox-index linux-trace-devel

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-trace-devel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git