From: Steven Rostedt <rostedt@goodmis.org>
To: Sameeruddin shaik <sameeruddin.shaik8@gmail.com>
Cc: linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH] trace-cmd: Fix lib audit warning message
Date: Wed, 13 Jan 2021 21:04:01 -0500 [thread overview]
Message-ID: <20210113210401.4299b2ed@oasis.local.home> (raw)
In-Reply-To: <1610606688-5186-1-git-send-email-sameeruddin.shaik8@gmail.com>
On Thu, 14 Jan 2021 12:14:48 +0530
Sameeruddin shaik <sameeruddin.shaik8@gmail.com> wrote:
Thanks Sameer!
Just FYI, this isn't that important for this patch, but just to inform
you about basic procedures (we follow the Linux kernel method). When
sending a second version of the patch, add a "v2" to the subject. That
is, "[PATCH v2] trace-cmd: Fix lib audit warning message". Then below
the Signed-off-by (after the "---") add a section of "Changes since
v1:" that gives a brief list of changes that were made in the new
version. But again, not a big deal for this one, but something to be
aware of for future patches :)
Anyway, I did a preliminary test, and it looks like you this applies
without issue. I'll add it tomorrow. Thanks!
-- Steve
> statically updated the warning message which we will get, when
> compiling trace-cmd without the libaudit library.
>
> Following are the the messages which will pop out when compiling
>
> Before:
> -------
> trace-profile.c:23:3: warning: #warning "lib audit not found, using raw syscalls " "(install libaudit-devel and try again)"
>
> After:
> -------
> trace-profile.c:23:3: warning: #warning "lib audit not found, using raw syscalls " "(install libaudit-devel(for fedora) or libaudit-dev(for debian/ubuntu) and try again)"
>
> Signed-off-by: Sameeruddin shaik <sameeruddin.shaik8@gmail.com>
> ---
> tracecmd/trace-profile.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tracecmd/trace-profile.c b/tracecmd/trace-profile.c
> index cfae2a2..9b5c385 100644
> --- a/tracecmd/trace-profile.c
> +++ b/tracecmd/trace-profile.c
> @@ -21,7 +21,7 @@
>
> #ifdef WARN_NO_AUDIT
> # warning "lib audit not found, using raw syscalls " \
> - "(install libaudit-devel and try again)"
> + "(install libaudit-devel(for fedora) or libaudit-dev(for debian/ubuntu) and try again)"
> #endif
>
> #define TASK_STATE_TO_CHAR_STR "RSDTtXZxKWP"
next prev parent reply other threads:[~2021-01-14 2:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-14 6:44 [PATCH] trace-cmd: Fix lib audit warning message Sameeruddin shaik
2021-01-14 2:04 ` Steven Rostedt [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-01-12 7:31 Sameeruddin Shaik
2021-01-12 17:29 ` Steven Rostedt
2021-01-13 16:10 ` sameeruddin shaik
2021-01-13 14:38 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210113210401.4299b2ed@oasis.local.home \
--to=rostedt@goodmis.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=sameeruddin.shaik8@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).