From: Steven Rostedt <rostedt@goodmis.org>
To: linux-trace-devel@vger.kernel.org
Subject: [PATCH 2/2] libtracefs: Have the options_map elements be each on their own line
Date: Tue, 02 Feb 2021 14:55:00 -0500 [thread overview]
Message-ID: <20210202200011.041636204@goodmis.org> (raw)
In-Reply-To: 20210202195458.176697224@goodmis.org
From: "Steven Rostedt (VMware)" <rostedt@goodmis.org>
In order to verify the order of the option names in the options_map array,
have each name on its own line. This is much easier to see the mapping when
compared to the enums in tracefs_options_id that represent them.
No function changes.
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
---
src/tracefs-tools.c | 51 +++++++++++++++++++++++++++++++++++++--------
1 file changed, 42 insertions(+), 9 deletions(-)
diff --git a/src/tracefs-tools.c b/src/tracefs-tools.c
index 7f69cde93115..e2dfc7b8acff 100644
--- a/src/tracefs-tools.c
+++ b/src/tracefs-tools.c
@@ -20,15 +20,48 @@
#define TRACE_CTRL "tracing_on"
static const char * const options_map[] = {
- "unknown", "annotate", "bin", "blk_cgname", "blk_cgroup", "blk_classic",
- "block", "context-info", "disable_on_free", "display-graph", "event-fork",
- "funcgraph-abstime", "funcgraph-cpu", "funcgraph-duration", "funcgraph-irqs",
- "funcgraph-overhead", "funcgraph-overrun", "funcgraph-proc", "funcgraph-tail",
- "func_stack_trace", "function-fork", "function-trace", "graph-time", "hex",
- "irq-info", "latency-format", "markers", "overwrite", "pause-on-trace",
- "printk-msg-only", "print-parent", "raw", "record-cmd", "record-tgid",
- "sleep-time", "stacktrace", "sym-addr", "sym-offset", "sym-userobj",
- "trace_printk", "userstacktrace", "verbose" };
+ "unknown",
+ "annotate",
+ "bin",
+ "blk_cgname",
+ "blk_cgroup",
+ "blk_classic",
+ "block",
+ "context-info",
+ "disable_on_free",
+ "display-graph",
+ "event-fork",
+ "funcgraph-abstime",
+ "funcgraph-cpu",
+ "funcgraph-duration",
+ "funcgraph-irqs",
+ "funcgraph-overhead",
+ "funcgraph-overrun",
+ "funcgraph-proc",
+ "funcgraph-tail",
+ "func_stack_trace",
+ "function-fork",
+ "function-trace",
+ "graph-time",
+ "hex",
+ "irq-info",
+ "latency-format",
+ "markers",
+ "overwrite",
+ "pause-on-trace",
+ "printk-msg-only",
+ "print-parent",
+ "raw",
+ "record-cmd",
+ "record-tgid",
+ "sleep-time",
+ "stacktrace",
+ "sym-addr",
+ "sym-offset",
+ "sym-userobj",
+ "trace_printk",
+ "userstacktrace",
+ "verbose" };
static int trace_on_off(int fd, bool on)
{
--
2.29.2
prev parent reply other threads:[~2021-02-02 20:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-02 19:54 [PATCH 0/2] libtracefs: Minor formating updates to options code Steven Rostedt
2021-02-02 19:54 ` [PATCH 1/2] tracefs: Use new BUILD_BUG_ON() and ARRAY_SIZE() macros for options_map intergity Steven Rostedt
2021-02-02 19:55 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210202200011.041636204@goodmis.org \
--to=rostedt@goodmis.org \
--cc=linux-trace-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).