From: Steven Rostedt <rostedt@goodmis.org>
To: "Tzvetomir Stoyanov (VMware)" <tz.stoyanov@gmail.com>
Cc: linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH v27 5/5] trace-cmd [POC]: Add KVM timestamp synchronization plugin
Date: Wed, 3 Feb 2021 15:21:14 -0500 [thread overview]
Message-ID: <20210203152114.4ea7674c@gandalf.local.home> (raw)
In-Reply-To: <20210201160339.506562-6-tz.stoyanov@gmail.com>
On Mon, 1 Feb 2021 18:03:39 +0200
"Tzvetomir Stoyanov (VMware)" <tz.stoyanov@gmail.com> wrote:
> +++ b/lib/trace-cmd/trace-timesync-kvm.c
> @@ -0,0 +1,460 @@
> +// SPDX-License-Identifier: LGPL-2.1
> +/*
> + * Copyright (C) 2020, VMware, Tzvetomir Stoyanov tz.stoyanov@gmail.com>
> + *
> + */
> +
> +#include <fcntl.h>
> +#include <stdlib.h>
> +#include <unistd.h>
> +#include <sys/stat.h>
> +#include <dirent.h>
> +
> +#include "trace-cmd.h"
> +#include "trace-cmd-private.h"
> +#include "tracefs.h"
> +#include "trace-tsync-local.h"
> +
> +#define KVM_DEBUG_FS "/sys/kernel/debug/kvm"
> +#define KVM_DEBUG_OFFSET_FILE "tsc-offset"
> +#define KVM_DEBUG_SCALING_FILE "tsc-scaling-ratio"
> +#define KVM_DEBUG_VCPU_DIR "vcpu"
> +
> +#define KVM_SYNC_PKT_REQUEST 1
> +#define KVM_SYNC_PKT_RESPONSE 2
> +
> +typedef __s64 s64;
> +
I have the same issue with __s64 on the one machine. Best to use:
typdef long long s64;
-- Steve
prev parent reply other threads:[~2021-02-03 20:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-01 16:03 [PATCH v27 0/5] Timestamp synchronization of host - guest tracing session Tzvetomir Stoyanov (VMware)
2021-02-01 16:03 ` [PATCH v27 1/5] trace-cmd: Add timestamp synchronization per vCPU Tzvetomir Stoyanov (VMware)
2021-02-03 20:20 ` Steven Rostedt
2021-02-04 12:31 ` Tzvetomir Stoyanov
2021-02-01 16:03 ` [PATCH v27 2/5] trace-cmd: Add dummy function to initialize timestamp sync logic Tzvetomir Stoyanov (VMware)
2021-02-01 16:03 ` [PATCH v27 3/5] trace-cmd: [POC] PTP-like algorithm for host - guest timestamp synchronization Tzvetomir Stoyanov (VMware)
2021-02-01 16:03 ` [PATCH v27 4/5] trace-cmd: Debug scripts for " Tzvetomir Stoyanov (VMware)
2021-02-01 16:03 ` [PATCH v27 5/5] trace-cmd [POC]: Add KVM timestamp synchronization plugin Tzvetomir Stoyanov (VMware)
2021-02-03 20:21 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210203152114.4ea7674c@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=tz.stoyanov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).