From: Steven Rostedt <rostedt@goodmis.org>
To: Linux Trace Devel <linux-trace-devel@vger.kernel.org>
Subject: [PATCH] trace-cmd: Fix SEGFAULT when no tsync_protos are supplied
Date: Wed, 3 Feb 2021 17:10:18 -0500 [thread overview]
Message-ID: <20210203171018.5b82a0a7@gandalf.local.home> (raw)
From: "Steven Rostedt (VMware)" <rostedt@goodmis.org>
The make_trace_resp() function takes in a tsync_proto string to add to the
message being sent. But if NULL is passed in, the call to strncpy() will
crash.
Just set it to a empty string, and pass that instead.
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
---
lib/trace-cmd/trace-msg.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/lib/trace-cmd/trace-msg.c b/lib/trace-cmd/trace-msg.c
index 611af2c1..79c1b8a1 100644
--- a/lib/trace-cmd/trace-msg.c
+++ b/lib/trace-cmd/trace-msg.c
@@ -1248,6 +1248,9 @@ static int make_trace_resp(struct tracecmd_msg *msg, int page_size, int nr_cpus,
{
int data_size;
+ if (!tsync_proto)
+ tsync_proto = "";
+
data_size = write_uints(NULL, 0, ports, nr_cpus);
msg->buf = malloc(data_size);
if (!msg->buf)
--
2.25.4
reply other threads:[~2021-02-03 22:11 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210203171018.5b82a0a7@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-trace-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).