* [PATCH] trace-cmd: Fix SEGFAULT when no tsync_protos are supplied
@ 2021-02-03 22:10 Steven Rostedt
0 siblings, 0 replies; only message in thread
From: Steven Rostedt @ 2021-02-03 22:10 UTC (permalink / raw)
To: Linux Trace Devel
From: "Steven Rostedt (VMware)" <rostedt@goodmis.org>
The make_trace_resp() function takes in a tsync_proto string to add to the
message being sent. But if NULL is passed in, the call to strncpy() will
crash.
Just set it to a empty string, and pass that instead.
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
---
lib/trace-cmd/trace-msg.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/lib/trace-cmd/trace-msg.c b/lib/trace-cmd/trace-msg.c
index 611af2c1..79c1b8a1 100644
--- a/lib/trace-cmd/trace-msg.c
+++ b/lib/trace-cmd/trace-msg.c
@@ -1248,6 +1248,9 @@ static int make_trace_resp(struct tracecmd_msg *msg, int page_size, int nr_cpus,
{
int data_size;
+ if (!tsync_proto)
+ tsync_proto = "";
+
data_size = write_uints(NULL, 0, ports, nr_cpus);
msg->buf = malloc(data_size);
if (!msg->buf)
--
2.25.4
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2021-02-03 22:11 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-03 22:10 [PATCH] trace-cmd: Fix SEGFAULT when no tsync_protos are supplied Steven Rostedt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).