[PATCH] kernel-shark: Fix compile error: ‘string’ in namespace ‘std’ does not name a type

[PATCH] kernel-shark: Fix compile error: ‘string’ in namespace ‘std’ does not name a type

[Tzvetomir Stoyanov (VMware)]

From: Tzvetomir (VMware)  Stoyanov <tz.stoyanov@gmail.com>

There is a compilation error when compiling KernelShark on Fedora 33
with c++ (GCC) 10.2.1:

  src/KsPlotTools.hpp:349:37: error: ‘string’ in namespace ‘std’ does not name a type

"string" should be included in that header file, as it is a direct
dependency.

Signed-off-by: Tzvetomir (VMware)  Stoyanov <tz.stoyanov@gmail.com>
---
 src/KsPlotTools.hpp | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/KsPlotTools.hpp b/src/KsPlotTools.hpp
index 1725926..68bd6f7 100644
--- a/src/KsPlotTools.hpp
+++ b/src/KsPlotTools.hpp
@@ -15,6 +15,7 @@
 // C++
 #include <forward_list>
 #include <unordered_map>
+#include <string>
 
 // KernelShark
 #include "libkshark.h"
-- 
2.29.2

Re: [PATCH] kernel-shark: Fix compile error: ‘string’ in namespace ‘std’ does not name a type

[Yordan Karadzhov (VMware)]

On 5.02.21 г. 13:12 ч., Tzvetomir Stoyanov (VMware) wrote:
> From: Tzvetomir (VMware)  Stoyanov <tz.stoyanov@gmail.com>
> 
> There is a compilation error when compiling KernelShark on Fedora 33
> with c++ (GCC) 10.2.1:
> 
>    src/KsPlotTools.hpp:349:37: error: ‘string’ in namespace ‘std’ does not name a type
> 
> "string" should be included in that header file, as it is a direct
> dependency.
> 
> Signed-off-by: Tzvetomir (VMware)  Stoyanov <tz.stoyanov@gmail.com>
> ---
>   src/KsPlotTools.hpp | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/src/KsPlotTools.hpp b/src/KsPlotTools.hpp
> index 1725926..68bd6f7 100644
> --- a/src/KsPlotTools.hpp
> +++ b/src/KsPlotTools.hpp
> @@ -15,6 +15,7 @@
>   // C++
>   #include <forward_list>
>   #include <unordered_map>
> +#include <string>
>   
>   // KernelShark
>   #include "libkshark.h"
> 

Thanks Ceco!

Reviewed-by: Yordan Karadzhov (VMware) <y.karadz@gmail.com>