Re: [PATCH] libtracefs: New API to trace only specific functions by instance

[Steven Rostedt <rostedt@goodmis.org>]

On Mon, 22 Feb 2021 18:10:40 +0530
Sameeruddin Shaik <sameeruddin.shaik8@gmail.com> wrote:

> hi steve,
> As you suggested, i have used an array of const pointers to const strings.
> This is the version-1 of the patch, it breaks in write.
> I faced two problems here
> 1. The above  code can't be able to write to  set_ftrace_filter file
> string by string (for normal files its working fine), After every
> successful write i am getting the count bytes written as supplied
> size, but strings are  not getting written in the set_ftrace_filter
> file. please give me any review or debug inputs on this

I'll take a look at your patch tomorrow.


> 2.I don't know how to reply to previous thread using git send-email, i
> apologize for that, please do let me know how to reply to the older
> threads
> using the git send-email.

Why do you need to reply to the previous thread with git send-email.
New versions of a patch should be their own thread and not a reply to
another thread.

That said, if you look at the headers of the email you want to reply
to, you'll see a Message-ID field. For example, your email that I'm
replying to has the message id of:

 Message-ID: <CAK7tX=bRRtcsAPWuiF8i5T2WnO_kSMKY7ar01f3Ki4awAC08rQ@mail.gmail.com>

Then I can use the part in between the '<' and '>' to send replies via
git send-email.

 git send-email '--in-reply-to=CAK7tX=bRRtcsAPWuiF8i5T2WnO_kSMKY7ar01f3Ki4awAC08rQ@mail.gmail.com'

Note the quotes used above. They may be needed to prevent bash from
interpreting anything inside the message ID.

And then the emails sent from git will be a reply to that email.

> Once i have the write functionality working fine, will implement the
> other features incrementally.

OK. Again, I'll take a look at your patch on Monday.

Thanks,

-- Steve