linux-trace-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Sameeruddin Shaik <sameeruddin.shaik8@gmail.com>
Cc: Tzvetomir Stoyanov <tz.stoyanov@gmail.com>,
	Linux Trace Devel <linux-trace-devel@vger.kernel.org>
Subject: Re: [Bug 210643] libtracefs: Add ways to set the filtering of function tracing
Date: Wed, 24 Feb 2021 09:19:35 -0500	[thread overview]
Message-ID: <20210224091935.767a8e0c@gandalf.local.home> (raw)
In-Reply-To: <CAK7tX=aOyq3O_p1S5xVP3FZuciU6g=TcP997Sv3bxbxTWiBL7Q@mail.gmail.com>

On Wed, 24 Feb 2021 15:04:51 +0530
Sameeruddin Shaik <sameeruddin.shaik8@gmail.com> wrote:

> hi,
> 
> >I forgot to include you on the Cc for this email.  
> 
> Not a problem at all steve , bugzilla daemon  sent me an update:)
> 
> I have read your requirements, I am thinking to give 3 incremental
> patches for this API
> 
> patch-1 : will write normal strings into the filter file
> patch-2: will handle the kernel glob expressions
> patch-3: will handle the regular expressions

Sure. You can send out a 3 patch set series and we can continue our
discussion on that.

> 
> >I think there should be a complementary API for deleting the filters,
> >may be something like
> >int tracefs_function_filter_remove(struct tracefs_instance *instance,
> >                                                        const char *
> > const *filters,
> >                                                       const char *module)
> > It should be able to remove the filters, configured by the first API
> > with the same "filters, module" input parameters.  
> 
> Tzvetomir,
> Let's wait for the steve inputs on this.

I agree with Tzvetomir, but let's worry about the addition of filters API
first, and then when we get that all settled out, we can add this one, as
this one should be much simpler (famous last words).

-- Steve

  reply	other threads:[~2021-02-24 15:42 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-23 17:01 Fw: [Bug 210643] libtracefs: Add ways to set the filtering of function tracing Steven Rostedt
2021-02-23 20:59 ` Steven Rostedt
2021-02-24  7:39 ` Fw: " Tzvetomir Stoyanov
2021-02-24  9:34   ` Sameeruddin Shaik
2021-02-24 14:19     ` Steven Rostedt [this message]
2021-02-24 14:17   ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210224091935.767a8e0c@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=linux-trace-devel@vger.kernel.org \
    --cc=sameeruddin.shaik8@gmail.com \
    --cc=tz.stoyanov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).