From: Steven Rostedt <rostedt@goodmis.org>
To: Tzvetomir Stoyanov <tz.stoyanov@gmail.com>
Cc: Linux Trace Devel <linux-trace-devel@vger.kernel.org>
Subject: Re: [PATCH v29 5/5] trace-cmd [POC]: Add KVM timestamp synchronization plugin
Date: Wed, 24 Feb 2021 18:19:38 -0500 [thread overview]
Message-ID: <20210224181938.59df57cd@gandalf.local.home> (raw)
In-Reply-To: <CAPpZLN4QvCFgqbSf8xb4LZrdSXY+g8CDpw72SeSpUqgaj64ayA@mail.gmail.com>
On Wed, 24 Feb 2021 08:22:42 +0200
Tzvetomir Stoyanov <tz.stoyanov@gmail.com> wrote:
> > Either way, we need to make sure there's no path that could cause the guest
> > (or host) to get stuck in the barrier.
>
> I think it is better to move the whole logic in the library - running
> the ptheads and
> synchronizing with mutex and barrier. The API caller (trace-cmd) will receive
> only a pthread_t id of the running thread, created by the library.
As long as the code is together and robust to prevent unexpected deadlocks.
-- Steve
prev parent reply other threads:[~2021-02-24 23:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-19 10:14 [PATCH v29 0/5] Timestamp synchronization of host - guest tracing session Tzvetomir Stoyanov (VMware)
2021-02-19 10:14 ` [PATCH v29 1/5] trace-cmd: Add timestamp synchronization per vCPU Tzvetomir Stoyanov (VMware)
2021-02-19 10:14 ` [PATCH v29 2/5] trace-cmd: Add dummy function to initialize timestamp sync logic Tzvetomir Stoyanov (VMware)
2021-02-19 10:14 ` [PATCH v29 3/5] trace-cmd: [POC] PTP-like algorithm for host - guest timestamp synchronization Tzvetomir Stoyanov (VMware)
2021-02-19 10:14 ` [PATCH v29 4/5] trace-cmd: Debug scripts for " Tzvetomir Stoyanov (VMware)
2021-02-19 10:14 ` [PATCH v29 5/5] trace-cmd [POC]: Add KVM timestamp synchronization plugin Tzvetomir Stoyanov (VMware)
2021-02-23 21:36 ` Steven Rostedt
2021-02-24 6:22 ` Tzvetomir Stoyanov
2021-02-24 23:19 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210224181938.59df57cd@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=tz.stoyanov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).