From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB997C433E6 for ; Wed, 24 Feb 2021 23:20:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8ABCA64F07 for ; Wed, 24 Feb 2021 23:20:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236205AbhBXXUa (ORCPT ); Wed, 24 Feb 2021 18:20:30 -0500 Received: from mail.kernel.org ([198.145.29.99]:34172 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234728AbhBXXUU (ORCPT ); Wed, 24 Feb 2021 18:20:20 -0500 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 37F5D64EDD; Wed, 24 Feb 2021 23:19:40 +0000 (UTC) Date: Wed, 24 Feb 2021 18:19:38 -0500 From: Steven Rostedt To: Tzvetomir Stoyanov Cc: Linux Trace Devel Subject: Re: [PATCH v29 5/5] trace-cmd [POC]: Add KVM timestamp synchronization plugin Message-ID: <20210224181938.59df57cd@gandalf.local.home> In-Reply-To: References: <20210219101457.2345089-1-tz.stoyanov@gmail.com> <20210219101457.2345089-6-tz.stoyanov@gmail.com> <20210223163632.438071c7@gandalf.local.home> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org Archived-At: List-Archive: List-Post: On Wed, 24 Feb 2021 08:22:42 +0200 Tzvetomir Stoyanov wrote: > > Either way, we need to make sure there's no path that could cause the guest > > (or host) to get stuck in the barrier. > > I think it is better to move the whole logic in the library - running > the ptheads and > synchronizing with mutex and barrier. The API caller (trace-cmd) will receive > only a pthread_t id of the running thread, created by the library. As long as the code is together and robust to prevent unexpected deadlocks. -- Steve