From: "Tzvetomir Stoyanov (VMware)" <tz.stoyanov@gmail.com>
To: rostedt@goodmis.org
Cc: linux-trace-devel@vger.kernel.org
Subject: [PATCH 11/12] trace-cmd: Add a new flag to disable any timestamp corrections
Date: Mon, 15 Mar 2021 08:18:31 +0200 [thread overview]
Message-ID: <20210315061832.168495-12-tz.stoyanov@gmail.com> (raw)
In-Reply-To: <20210315061832.168495-1-tz.stoyanov@gmail.com>
A new flag is added in the trace-cmd library for controlling events
timestamp corrections while reading a trace file. If the flag is set,
all timestamps are displayed as-is from the trace file.
TRACECMD_FL_RAW_TS
The flag can be modified with these APIs:
tracecmd_set_flag()
tracecmd_clear_flag()
Signed-off-by: Tzvetomir Stoyanov (VMware) <tz.stoyanov@gmail.com>
---
lib/trace-cmd/include/private/trace-cmd-private.h | 1 +
lib/trace-cmd/trace-input.c | 12 ++++++++----
2 files changed, 9 insertions(+), 4 deletions(-)
diff --git a/lib/trace-cmd/include/private/trace-cmd-private.h b/lib/trace-cmd/include/private/trace-cmd-private.h
index e2ea0dd0..98616c76 100644
--- a/lib/trace-cmd/include/private/trace-cmd-private.h
+++ b/lib/trace-cmd/include/private/trace-cmd-private.h
@@ -132,6 +132,7 @@ enum {
TRACECMD_FL_IGNORE_DATE = (1 << 0),
TRACECMD_FL_BUFFER_INSTANCE = (1 << 1),
TRACECMD_FL_IN_USECS = (1 << 2),
+ TRACECMD_FL_RAW_TS = (1 << 3),
};
struct tracecmd_ftrace {
diff --git a/lib/trace-cmd/trace-input.c b/lib/trace-cmd/trace-input.c
index 1cffa0f5..b53c1932 100644
--- a/lib/trace-cmd/trace-input.c
+++ b/lib/trace-cmd/trace-input.c
@@ -1288,6 +1288,9 @@ static unsigned long long timestamp_calc(unsigned long long ts,
{
unsigned long long t = ts;
+ /* do not modify raw timestamps */
+ if (handle->flags & TRACECMD_FL_RAW_TS)
+ return ts;
/* Guest trace file, sync with host timestamps */
if (handle->host.sync_enable)
@@ -2603,7 +2606,8 @@ static int handle_options(struct tracecmd_input *handle)
* gtod. It is stored as ASCII with '0x'
* appended.
*/
- if (handle->flags & TRACECMD_FL_IGNORE_DATE)
+ if ((handle->flags & TRACECMD_FL_IGNORE_DATE) ||
+ (handle->flags & TRACECMD_FL_RAW_TS))
break;
offset = strtoll(buf, NULL, 0);
/* Convert from micro to nano */
@@ -2615,7 +2619,7 @@ static int handle_options(struct tracecmd_input *handle)
* Similar to date option, but just adds an
* offset to the timestamp.
*/
- if (handle->flags & TRACECMD_FL_IGNORE_DATE)
+ if (handle->flags & TRACECMD_FL_RAW_TS)
break;
offset = strtoll(buf, NULL, 0);
handle->ts_offset += offset;
@@ -2630,7 +2634,7 @@ static int handle_options(struct tracecmd_input *handle)
* long long array of size [count] of timestamp offsets.
* long long array of size [count] of timestamp scaling ratios.*
*/
- if (size < 16 || handle->flags & TRACECMD_FL_IGNORE_DATE)
+ if (size < 16 || (handle->flags & TRACECMD_FL_RAW_TS))
break;
handle->host.peer_trace_id = tep_read_number(handle->pevent,
buf, 8);
@@ -2709,7 +2713,7 @@ static int handle_options(struct tracecmd_input *handle)
trace_guest_load(handle, buf, size);
break;
case TRACECMD_OPTION_TSC2NSEC:
- if (size != 12)
+ if (size != 12 || (handle->flags & TRACECMD_FL_RAW_TS))
break;
handle->tsc_calc.mult = tep_read_number(handle->pevent,
buf, 4);
--
2.29.2
next prev parent reply other threads:[~2021-03-15 6:19 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-15 6:18 [PATCH 00/12] TSC trace clock to nanosecond conversion Tzvetomir Stoyanov (VMware)
2021-03-15 6:18 ` [PATCH 01/12] trace-cmd: Add initial perf interface in trace-cmd library Tzvetomir Stoyanov (VMware)
2021-03-15 21:59 ` Steven Rostedt
2021-03-15 6:18 ` [PATCH 02/12] trace-cmd: Add logic for TSC to nanosecond conversion Tzvetomir Stoyanov (VMware)
2021-03-16 21:17 ` Steven Rostedt
2021-03-17 9:57 ` Tzvetomir Stoyanov
2021-03-17 21:49 ` Steven Rostedt
2021-03-18 3:42 ` Tzvetomir Stoyanov
2021-03-18 13:59 ` Steven Rostedt
2021-03-15 6:18 ` [PATCH 03/12] trace-cmd: Append new options into guest trace file at the end of the tracing session Tzvetomir Stoyanov (VMware)
2021-03-15 6:18 ` [PATCH 04/12] trace-cmd: Add a new option in trace file metadata for tsc2nsec conversion Tzvetomir Stoyanov (VMware)
2021-03-15 6:18 ` [PATCH 05/12] trace-cmd: Save information for tsc to nanoseconds conversion in trace file Tzvetomir Stoyanov (VMware)
2021-03-15 6:18 ` [PATCH 06/12] trace-cmd: Read information for tsc to nanoseconds conversion from " Tzvetomir Stoyanov (VMware)
2021-03-15 6:18 ` [PATCH 07/12] trace-cmd: Remove unneeded multiply in events timestamp reading Tzvetomir Stoyanov (VMware)
2021-03-15 6:18 ` [PATCH 08/12] trace-cmd: Perform all timestamp corrections in a single function Tzvetomir Stoyanov (VMware)
2021-03-15 6:18 ` [PATCH 09/12] trace-cmd: Convert tsc timestamps to nanosecods when reading trace data from a file Tzvetomir Stoyanov (VMware)
2021-03-16 21:25 ` Steven Rostedt
2021-03-15 6:18 ` [PATCH 10/12] trace-cmd: Set order and priorities when applying timestamp corrections Tzvetomir Stoyanov (VMware)
2021-03-16 21:28 ` Steven Rostedt
2021-03-15 6:18 ` Tzvetomir Stoyanov (VMware) [this message]
2021-03-15 6:18 ` [PATCH 12/12] trace-cmd: Add new parameter "--raw-ts" to "trace-cmd report" command Tzvetomir Stoyanov (VMware)
2021-03-16 21:29 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210315061832.168495-12-tz.stoyanov@gmail.com \
--to=tz.stoyanov@gmail.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).